Fix curl/HTTPS transport, update head.hackage hash, rename check-run step#229
Merged
Conversation
The hydra-github-bridge no longer prefixes check-run names with "ci/hydra-build:" for zw3rk CI. Update the step name to match. The JQ filters and wait-for-hydra action (check: required) now work correctly with the bare job names.
The head.hackage index is a rolling target — upstream published new packages, invalidating the previous hash. specified: sha256-nFFut7+8NzUps+4MsmnAo2bLp1EE2Dx4eWqTeZ2aYqI= got: sha256-P0hOiQyh54Y5Pyl9rjpEE5Er/u83aeXIKBygzniRZtk=
The wrapped-cabal writeShellApplication includes curl as a runtimeInput, but that only puts curl on PATH when the wrapper script itself runs. In the -env container scripts (which source $stdenv/setup to construct PATH from buildInputs/nativeBuildInputs), curl is NOT on PATH for other programs. This breaks GHC CI builds: GHC's Makefile bootstraps its own stage0 cabal (debug build, no native TLS) which then needs curl on PATH to download packages from Hackage over HTTPS. Without curl available, it fails with Cabal-7113. Fix: add curl directly to buildInputs/nativeBuildInputs in dynamic.nix, static.nix, and cross-js.nix so it's always available on PATH regardless of how the environment is sourced.
angerman
force-pushed
the
fix/drop-cabal-experimental
branch
from
64d6441 to
76d6b37
Compare
angerman
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeShellApplicationruntimeInputsviapropagatedNativeBuildInputsso$stdenv/setup(sourced by-envcontainer scripts) transitively adds them to PATH for the whole shell environment — fixes HTTPS transport unavailable error (Cabal-7113) where other programs (e.g. GHC's bootstrap cabal) couldn't findcurltool-map.nix(upstream index updated)Why runtimeInputs weren't visible in -env scripts
The switch from
nix print-dev-envtodevShellTools(a354771) changed how-envscripts reconstruct the shell environment.writeShellApplicationembedsruntimeInputsin the wrapper's own inline PATH, but$stdenv/setuponly walksbuildInputs/nativeBuildInputs— not the internal PATH of wrappers. UsingpropagatedNativeBuildInputson the wrapper derivation is the standard Nix mechanism to make these dependencies transitively visible.Test plan
ci/hydra-build:prefix)