Add which to all shell environments#234
Merged
Merged
Conversation
GHC's build system (mk/boilerplate.mk:182) uses `which` to locate ghc. After commit a354771 switched from recursive-nix `nix print-dev-env` to `devShellTools.unstructuredDerivationInputEnv`, `which` was no longer transitively included. This caused CI failures: make[1]: which: No such file or directory ../mk/boilerplate.mk:182: *** Cannot find ghc: . Stop. Add pkgs.which explicitly to nativeBuildInputs/buildInputs in all four shell definitions (dynamic, static, cross-js, cross-windows).
angerman
force-pushed
the
fix/cacert-for-curl
branch
from
b9fe78e to
3725e1f
Compare
angerman
changed the title
which to all shell environments
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GHC's build system (
mk/boilerplate.mk:182) useswhichto locateghc. After the switch todevShellTools+source "$stdenv/setup"(a354771), the-envscripts build a hermetic PATH from stdenv'sinitialPathand the declaredbuildInputs/nativeBuildInputs. Sincewhichis not part of stdenv'sinitialPathand was never explicitly listed, it is missing — causing CI failures:Add
pkgs.whichto all four shell definitions (dynamic, static, cross-js, cross-windows).Test plan
nix develop .#ghc98-minimal-ghc -c which which→/nix/store/...-which-2.23/bin/whichtestsuite/timeoutbuilds withoutCannot find ghcerror