Only generate valid names for FsPath tests
#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/71-fspath
branch
3 times, most recently
from
26d31c3 to
66fa5f5
Compare
jorisdral
force-pushed
the
jdral/71-fspath
branch
from
66fa5f5 to
c8998df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71
The names for directories and files that we used in
FsPathtests were too arbitrary. The documentation ofFsPathnow describes a number of invariants that should ensure thatFsPaths make sense. Currently, the user is responsible for ensuring that these invariants are satisfied. It might be nice to dynamically check these invariants instead, see #73