Allow downsize on verifier params
#7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkerber
force-pushed
the
tkerber/downsize-verifier-params
branch
from
9988f8a to
b7e49d5
Compare
iquerejeta
requested review from
davidnevadoc
and removed request for
miguel-ambrona
iquerejeta
referenced
this pull request
in midnightntwrk/halo2
Apr 8, 2025
We mutate the polynomial (with all zeroes) to be consistent with the behaviour.
iquerejeta
referenced
this pull request
in midnightntwrk/halo2
Apr 14, 2025
We mutate the polynomial (with all zeroes) to be consistent with the behaviour.
iquerejeta
referenced
this pull request
in midnightntwrk/halo2
May 20, 2025
* Compare polynomials and polynomial commitments by reference. Issue #1 Not permit duplicate queries Issue #3 * Add Length of PIs to the transcript Issue #2 * Check trailing bytes Issue #6 * Panic if two points are equals in lagrange_interpolate. Issue input-output-hk#10 * Hash the byte representation of the VK in the transcript Issue #5 We do not add the architecture, as the verifier is already parametrised by that. * Consistency in polynomial multiplication Issue #7 We mutate the polynomial (with all zeroes) to be consistent with the behaviour. * Make commitment homomorphic, and don't send evals of pieces - Issue#0
dkaidalov
pushed a commit
that referenced
this pull request
Jul 1, 2025
* FS: add instance length before instances and not after (more intuitive) * prover: rename variable * add support for committed instances * examples: adapt [vector-ops-unblinded] to test committed instances * prover: create support for [commit_to_instances] * examples: generalize example on committed instances * Address PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently required, as verification checks
nand/orkagainst the proof / verifier key, and fails if these do not match. As a result, I need to be able to interpret the params as ones with a lowerk, even if this is a noop.