Draft: Add GHC 9.4.7 #2030
Closed
Draft: Add GHC 9.4.7 #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
cydparser
reviewed
Aug 25, 2023
| ++ final.lib.optionals (final.stdenv.targetPlatform.isWindows) (fromUntil "9.4.1" "9.4.5" ./patches/ghc/ghc-9.4-hadrian-win-cross.patch) | ||
| ++ final.lib.optionals (final.stdenv.targetPlatform.isWindows) (fromUntil "9.8.1" "9.10" ./patches/ghc/ghc-9.8-hadrian-win-cross.patch) | ||
| ++ fromUntil "9.4.5" "9.4.6" ./patches/ghc/ghc-9.4.5-include-order-fix.patch | ||
| ++ fromUntil "9.4.5" "9.4.7" ./patches/ghc/ghc-9.4.5-include-order-fix.patch |
Contributor
There was a problem hiding this comment.
The upper bound should be "9.4.8" to include 9.4.7.
Contributor
Author
|
Closing in favour of #2031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GHC 9.4.7. At the moment this is very much draft since GHC 9.4.7 hasn't been officially released yet, but I thought I'd get a head start on this.
There seems to be some issues with building the windows cross stuff. It looks to be something similar to what's solved by the "ghc-9.4.5-include-order-fix" patch, but I'm not sure what exactly is going on there.
I've generated the materializations for the other arches that I can build. I haven't run the test suite, so I haven't updated broken tests.