Skip to content

Conversation

@coot
Copy link
Collaborator

@coot coot commented Apr 26, 2023

  • io-classes: fixed building haddocks with ghc-8.10
  • version 1.1.0.0

@coot coot requested a review from jorisdral April 26, 2023 12:29
@coot coot force-pushed the coot/ghc-8.10-fix branch from a11754c to 0d78e19 Compare April 26, 2023 12:41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## Next version should be replaced by ## 1.1.0.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

mtl,

io-classes ^>= 1.0.0.0,
io-classes >= 1.0 && < 1.2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no changelog entry for this change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because I will just add a revision on hackage, no need to bump its version.

time >=1.9.1 && <1.13,

io-classes ^>=1.0
io-classes >=1.0 && <1.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the only change made to the package between 1.0.0.0 and 1.1.0.0, would a revision of 1.0.0.0 be sufficient? Or is it the goal to release the packages in lockstep with the same version for each package?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do release io-classes, io-sim, strict-stm, strict-mvar and si-timers (but not io-classes-mtl) in lock step, but I am fine to be more relaxed with lower bounds when I am sure things will still work.

TypeFamilies
build-depends: base >=4.9 && <4.19,
io-classes ^>=1.0,
io-classes ^>=1.1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would >= 1.0 && < 1.2 also suffice? I think building with 1.0 would cause some deprecation warnings to be emitted with respect to moving the MonadMVar module, but would it lead to actual build failures?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this because io-sim:test would fail to compile with io-classes-1.0.

Comment on lines +3 to +8
## 1.1.0.0

### Non breaking changes

* `io-classes-1.1.0.0`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coot coot force-pushed the coot/ghc-8.10-fix branch from 0d78e19 to 5c2526e Compare April 26, 2023 13:04
Copy link
Contributor

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot force-pushed the coot/ghc-8.10-fix branch from 5c2526e to aa071c9 Compare April 26, 2023 13:11
@coot coot enabled auto-merge April 26, 2023 13:13
@coot coot added this pull request to the merge queue Apr 26, 2023
@coot coot self-assigned this Apr 26, 2023
@coot coot added documentation Improvements or additions to documentation ghc-8.10 Issues / PRs related to `ghc-8.10` labels Apr 26, 2023
Merged via the queue into main with commit df0ddc9 Apr 26, 2023
@coot coot deleted the coot/ghc-8.10-fix branch April 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ghc-8.10 Issues / PRs related to `ghc-8.10`

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants