Run debugger 1.1 #21
Merged
Run debugger 1.1 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksaric
approved these changes
Jun 26, 2018
| @@ -1,5 +1,5 @@ | |||
| name: log-classifier | |||
| version: 1.0.0.0 | |||
| version: 1.1.0.0 | |||
| toJSON (Ticket comment tags) = | ||
| object [ "ticket" .= object | ||
| [ "comment" .= comment | ||
| , "assignee_id" .= assignee |
Contributor
There was a problem hiding this comment.
This means we don't change the assignee ever, right?
| \(ticketInfos :: [TicketInfo]) -> | ||
| length (filterAnalyzedTickets ticketInfos) `shouldBe` 0 | ||
|
|
||
| it "should filter analyzed tickets v1.1" $ |
Contributor
There was a problem hiding this comment.
Nice, even though the other scenario should be tested when testing - the one where all of the tickets have the tag, or some of the issues have the tag. Never mind for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
analyzed-by-script-v1.1