[TSD-77] Fix two documentation issues that caused Hoogle to break #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksaric
suggested changes
Jul 16, 2018
Contributor
ksaric
left a comment
ksaric
left a comment
There was a problem hiding this comment.
stack hoogle seems to work now, good job.
Just remove the second comment since it's confusing to leave it as such, while also it still reports the error which is making Hoogle unable to build:
src/Lib.hs:559:71: error:
parse error on input ‘-- ^ ticketStatus == "new"’
|
559 | isTicketOpen TicketInfo{..} = tiStatus `elem` unsolvedTicketStatus-- ^ ticketStatus == "new"
src/Lib.hs
Outdated
|
|
||
| isTicketOpen :: TicketInfo -> Bool | ||
| isTicketOpen TicketInfo{..} = tiStatus `elem` unsolvedTicketStatus-- || ticketStatus == "new" | ||
| isTicketOpen TicketInfo{..} = tiStatus `elem` unsolvedTicketStatus-- ^ ticketStatus == "new" |
Contributor
There was a problem hiding this comment.
You can drop this comment, this was left and we don't need it anymore.
Contributor
Author
|
I am not sure as to how to make sure that Hoogle can properly generate documentation. I tried with |
Contributor
|
@mdimjasevic Yes, as I already mentioned, that should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iohk.myjetbrains.com/youtrack/issue/TSD-77
Hoogle cannot generate documentation for the log-classifier project due to incorrect documentation formatting in two places. These need to be fixed so that Hoogle can be used with the project.