[TSD-86] Create visual architecture of the project #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdimjasevic
suggested changes
Jul 26, 2018
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Tests don't compile:
/home/marko/projects/iohk/log-classifier/ksaric-tsd-86-documentation/test/Spec.hs:10:1: error:
Could not find module ‘DataSource’
it is a hidden module in the package ‘log-classifier-1.2.0.0’
Use -v to see a list of the files searched for.
|
10 | import DataSource (App, Attachment (..), Comment (..), Config (..), DeletedTicket (..),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...
mdimjasevic
reviewed
Jul 26, 2018
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Apart from tests not compiling, everything else looks good.
Contributor
Author
|
Whoops. Good catch. |
mdimjasevic
approved these changes
Jul 26, 2018
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Great, tests work now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iohk.myjetbrains.com/youtrack/issue/TSD-86
Adding some documentation and refactoring the code to match it.