[TSD-97] to_be_analysed tag removed by debugger. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksaric
commented
Aug 2, 2018
| in all (`elem` responseTags) mergedTags | ||
| -- in summary, the response tags have the debuggers `analyzed-by-script-version` tag AND | ||
| -- they remove the `to_be_analysed` tag AND they are unique. | ||
| in (filter (/= renderTicketStatus ToBeAnalyzed) . nub $ renderTicketStatus AnalyzedByScriptV1_3 : mergedTags) === responseTags |
Contributor
Author
There was a problem hiding this comment.
The good thing about this is this will fail once we increase the tag version.
Contributor
There was a problem hiding this comment.
Ah, thank you for letting me know! I'm be careful about it
HirotoShioi
approved these changes
Aug 3, 2018
| in all (`elem` responseTags) mergedTags | ||
| -- in summary, the response tags have the debuggers `analyzed-by-script-version` tag AND | ||
| -- they remove the `to_be_analysed` tag AND they are unique. | ||
| in (filter (/= renderTicketStatus ToBeAnalyzed) . nub $ renderTicketStatus AnalyzedByScriptV1_3 : mergedTags) === responseTags |
Contributor
There was a problem hiding this comment.
Ah, thank you for letting me know! I'm be careful about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iohk.myjetbrains.com/youtrack/issue/TSD-97
Removing the tag after the debugger run.
Required for the next debugger run.