[TSD-119] Update version, run debugger #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdimjasevic
reviewed
Aug 10, 2018
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Can you please link to the YouTrack issue? I can't add it to the PR description. It should be: https://iohk.myjetbrains.com/youtrack/issue/TSD-119
mdimjasevic
approved these changes
Aug 10, 2018
Contributor
|
I am not sure what debugger we're talking about here. All I can tell that happens in this PR based on the code changed is that you changed the version from 1.4.0.0 to 1.4.1.0. |
ksaric
approved these changes
Aug 10, 2018
Contributor
ksaric
left a comment
ksaric
left a comment
There was a problem hiding this comment.
LGTM, just add the logs before merging.
Contributor
Author
|
Good point, I've added the link! |
robcohen
approved these changes
Aug 13, 2018
Contributor
robcohen
left a comment
robcohen
left a comment
There was a problem hiding this comment.
Everything compiles and appears good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Youtrack: https://iohk.myjetbrains.com/youtrack/issue/TSD-119
Update the version to run the debugger.
At glance, it seems like there's changes other than bumping the version but this is because I've done formatting.