[CO 280] Switch to universum #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 10, 2018 10:10
…y datatype that has different show instance than base one
HirotoShioi
force-pushed
the
co-280-switch-to-universum
branch
2 times, most recently
from
bf37cb5 to
79ab4a5
Compare
HirotoShioi
force-pushed
the
co-280-switch-to-universum
branch
from
79ab4a5 to
f5006bd
Compare
HirotoShioi
force-pushed
the
co-280-switch-to-universum
branch
2 times, most recently
from
f25c7d2 to
6ca16a7
Compare
HirotoShioi
force-pushed
the
co-280-switch-to-universum
branch
from
6ca16a7 to
5c85880
Compare
added 2 commits
May 17, 2018 18:00
HirotoShioi
force-pushed
the
co-280-switch-to-universum
branch
from
6a1050b to
e637a9a
Compare
ksaric
approved these changes
May 17, 2018
| e <- quotedField | ||
| _ <- char ',' | ||
| _ <- char '"' | ||
| () <$ char ',' |
Contributor
There was a problem hiding this comment.
Revert this, it's really not that readable. There are two options:
- use the previous version -
_ <- char ',', which I prefer - use
void-void $ char ','
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the code to use universum
Linked Issues
https://iohk.myjetbrains.com/youtrack/issue/CO-280
Branched from this PR
Note
I did follow the migration guide written on the package document but I might have missed something. Please check carefully!