Fix JsonRpcControllerFixture Scala 3 MockFactory compatibility

- Converted JsonRpcControllerFixture to accept implicit MockFactory parameter
- Created JsonRpcControllerTestSupport trait for test specs to provide implicit MockFactory
- Updated all JsonRpcController test specs to extend JsonRpcControllerTestSupport
- Fixed validators mock expectation setup to work with imported MockFactory context
- Resolved all 202 JsonRpcControllerFixture compilation errors

The solution uses a factory pattern where the test spec (which extends MockFactory and TestSuite) provides itself as an implicit MockFactory to the fixture. This works around Scala 3's limitation where anonymous classes created by 'new' don't automatically satisfy MockFactory's TestSuite self-type requirement.

Co-authored-by: realcodywburns <13103499+realcodywburns@users.noreply.github.com>

Author: Copilot

src/test/scala/com/chipprbots/ethereum/jsonrpc/JsonRpcControllerEthLegacyTransactionSpec.scala

@@ -42,6 +42,7 @@ class JsonRpcControllerEthLegacyTransactionSpec
     with Matchers
     with JRCMatchers
     with org.scalamock.scalatest.MockFactory
+    with JsonRpcControllerTestSupport
     with ScalaCheckPropertyChecks
     with ScalaFutures
     with LongPatience

src/test/scala/com/chipprbots/ethereum/jsonrpc/JsonRpcControllerEthSpec.scala

@@ -59,6 +59,7 @@ class JsonRpcControllerEthSpec
     with JRCMatchers
     with ScalaCheckPropertyChecks
     with org.scalamock.scalatest.MockFactory
+    with JsonRpcControllerTestSupport
     with ScalaFutures
     with LongPatience
     with Eventually {

src/test/scala/com/chipprbots/ethereum/jsonrpc/JsonRpcControllerFixture.scala

@@ -40,11 +40,23 @@ import com.chipprbots.ethereum.nodebuilder.ApisBuilder
 import com.chipprbots.ethereum.utils.Config
 import com.chipprbots.ethereum.utils.FilterConfig
 
-class JsonRpcControllerFixture(implicit system: ActorSystem)
+/** Factory for creating JsonRpcControllerFixture instances with mocks.
+  * This is needed because in Scala 3, MockFactory requires TestSuite self-type,
+  * which anonymous classes created by 'new' don't satisfy.
+  */
+object JsonRpcControllerFixture {
+  def apply()(implicit system: ActorSystem, mockFactory: org.scalamock.scalatest.MockFactory): JsonRpcControllerFixture = {
+    new JsonRpcControllerFixture()(system, mockFactory)
+  }
+}
+
+class JsonRpcControllerFixture(implicit system: ActorSystem, mockFactory: org.scalamock.scalatest.MockFactory)
     extends EphemBlockchainTestSetup
     with JsonMethodsImplicits
-    with ApisBuilder
-    with org.scalamock.scalatest.MockFactory {
+    with ApisBuilder {
+
+  // Import all mockFactory members to enable mock creation and expectations
+  import mockFactory._
 
   def config: JsonRpcConfig = JsonRpcConfig(Config.config, available)
 
@@ -61,11 +73,14 @@ class JsonRpcControllerFixture(implicit system: ActorSystem)
   val syncingController: TestProbe = TestProbe()
 
   override lazy val stxLedger: StxLedger = mock[StxLedger]
-  override lazy val validators: ValidatorsExecutor = mock[ValidatorsExecutor]
-  (() => validators.signedTransactionValidator)
-    .expects()
-    .returns(null)
-    .anyNumberOfTimes()
+  override lazy val validators: ValidatorsExecutor = {
+    val v = mock[ValidatorsExecutor]
+    (() => v.signedTransactionValidator)
+      .expects()
+      .returns(null)
+      .anyNumberOfTimes()
+    v
+  }
 
   override lazy val mining: TestMining = buildTestMining()
     .withValidators(validators)

src/test/scala/com/chipprbots/ethereum/jsonrpc/JsonRpcControllerPersonalSpec.scala

@@ -35,6 +35,7 @@ class JsonRpcControllerPersonalSpec
     with Matchers
     with JRCMatchers
     with org.scalamock.scalatest.MockFactory
+    with JsonRpcControllerTestSupport
     with ScalaCheckPropertyChecks
     with ScalaFutures
     with LongPatience

src/test/scala/com/chipprbots/ethereum/jsonrpc/JsonRpcControllerSpec.scala

@@ -45,6 +45,7 @@ class JsonRpcControllerSpec
     with Matchers
     with JRCMatchers
     with org.scalamock.scalatest.MockFactory
+    with JsonRpcControllerTestSupport
     with ScalaCheckPropertyChecks
     with ScalaFutures
     with LongPatience

src/test/scala/com/chipprbots/ethereum/jsonrpc/JsonRpcControllerTestSupport.scala

@@ -0,0 +1,16 @@
+package com.chipprbots.ethereum.jsonrpc
+
+import org.scalamock.scalatest.MockFactory
+
+/** Support trait for JsonRpcController tests that use JsonRpcControllerFixture.
+  *
+  * In Scala 3, MockFactory requires TestSuite self-type, which anonymous classes
+  * created by 'new JsonRpcControllerFixture' don't satisfy. This trait provides
+  * the test spec itself as an implicit MockFactory so that JsonRpcControllerFixture
+  * can delegate mock creation to the test spec.
+  *
+  * Usage: Mix this trait into test specs that use JsonRpcControllerFixture.
+  */
+trait JsonRpcControllerTestSupport { self: MockFactory =>
+  implicit protected def mockFactoryProvider: MockFactory = this
+}