Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 1, 2025

Content

This PR includes the update of the signed entity type timeouts.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2826

@jpraynaud jpraynaud self-assigned this Dec 1, 2025
@jpraynaud jpraynaud requested a review from Copilot December 1, 2025 16:13
Copilot finished reviewing on behalf of jpraynaud December 1, 2025 16:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the timeout values for signed entity types in the get_open_message_timeout method. The changes align with issue #2826 and adjust timeout durations based on the specific requirements for each signed entity type, with MithrilStakeDistribution now having the longest timeout (3600s/1 hour).

Key Changes

  • Updated timeout values for all signed entity types with MithrilStakeDistribution changed from None to 3600s, CardanoImmutableFilesFull from None to 600s, CardanoStakeDistribution from 600s to 1800s, and CardanoTransactions/CardanoDatabase reduced from 1800s to 600s
  • Version bumps for mithril-stm (0.6.1 → 0.6.2) and mithril-common (0.6.29 → 0.6.30)
  • Cleanup of Makefile removing non-existent --features full flag

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mithril-common/src/entities/signed_entity_type.rs Updated timeout durations for all signed entity type variants in get_open_message_timeout method
mithril-common/Cargo.toml Bumped version from 0.6.29 to 0.6.30
mithril-stm/Cargo.toml Bumped version from 0.6.1 to 0.6.2
Cargo.lock Updated dependency versions to match Cargo.toml changes
mithril-common/Makefile Removed --features full flag from build, test, doc, and bench commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Test Results

    4 files  ±0    168 suites  ±0   23m 59s ⏱️ +18s
2 223 tests +1  2 223 ✅ +1  0 💤 ±0  0 ❌ ±0 
6 933 runs  +4  6 933 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit a5c22a0. ± Comparison against base commit 8f12c05.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2826-update-signed-entity-type-timeout branch from dd2be81 to 5283276 Compare December 1, 2025 16:20
@jpraynaud jpraynaud requested a review from Alenar December 1, 2025 16:48
* mithril-common from `0.6.29` to `0.6.30`
@jpraynaud jpraynaud force-pushed the jpraynaud/2826-update-signed-entity-type-timeout branch from 5283276 to a5c22a0 Compare December 2, 2025 08:59
@jpraynaud jpraynaud merged commit 17fe97e into main Dec 2, 2025
41 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2826-update-signed-entity-type-timeout branch December 2, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise expiration delays for signed entity types

3 participants