fix(ci): crates already published guard was not working #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add missing user agent when requesting crates.io api for the latest published version of a crate. Explaination: The retrieval of the remote version on crates.io api was failing. To request their api they ask for an user agent in order to have a contact point if needed, if missing the request is rejected.
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
deleted the
djo/2824/ci/publish-crate-should-not-fail-if-already-published
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix for the mechanism that avoid crates publication when a crate version is already published.
The retrieval of the remote version on crates.io api was failing. To request their api they ask for an user agent in order to have a contact point if needed, if missing the request is rejected.
More details on the fixed failure here.
Pre-submit checklist
Issue(s)
Closes #2824