Merged
Conversation
NSeydoux
force-pushed
the
JCL-337_use-verify-endpoint
branch
from
898bfb9 to
56a34be
Compare
acoburn
approved these changes
Jun 14, 2023
Collaborator
acoburn
left a comment
acoburn
left a comment
There was a problem hiding this comment.
LGTM, one minor comment that isn't really required to fix now (more of an FYI)
Call verify to check the validity of the issued grant, and the invalidity of the revoked grant.
The mock is stateful: an access grant is considered valid until a revocation request has been made, and it is then considered invalid.
This test is out of scope for this PR
Enforce support of Java 8 runtime.
NSeydoux
force-pushed
the
JCL-337_use-verify-endpoint
branch
from
8260323 to
b051b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call verify to check the validity of the issued grant, and the invalidity of the revoked grant.