Remove unnecessary type assertion in getProfileAll#1530
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b9c891:
|
3 tasks
ThisIsMissEm
approved these changes
Mar 21, 2022
Contributor
ThisIsMissEm
left a comment
ThisIsMissEm
left a comment
There was a problem hiding this comment.
LGTM, but do double check how this looks in the documentation, as to whether it's clear there.
NSeydoux
force-pushed
the
chore/webid-no-type-assertion
branch
from
971b747 to
a84a616
Compare
NSeydoux
force-pushed
the
chore/webid-no-type-assertion
branch
from
a84a616 to
34bd132
Compare
This introduces an overload to cleanly define the return type of getProfileAll, namely it the WebID profile is NOT provided, the return type includes that of `getSolidDataset`, and if it IS provided then the return type includes the generics instanciated by the provided WebID profile. Making this distinction allows to remove a type assertion from the implementation.
NSeydoux
force-pushed
the
chore/webid-no-type-assertion
branch
from
34bd132 to
56dc2c6
Compare
Contributor
Author
|
Not too bad actually: https://solid-client-js-ni3xdinux-inrupt.vercel.app/modules/profile_webid.html ! I just removed the type parameter from the overload where it isn't necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces an overload to cleanly define the return type of getProfileAll, namely it the WebID profile is NOT provided, the return type includes that of
getSolidDataset, and if it IS provided then the return type includes the generics instanciated by the provided WebID profile. Making this distinction allows to remove a type assertion from the implementation.