SDK-3368: Feature flag problem details tests#2526
Merged
Conversation
The end-to-end tests need to run against older supported versions of ESS, not all of which support problem details. By default, only the response status and title are checked, which are provided by default against any HTTP response. Problem details and instance are only checked if the environment variable E2E_TEST_FEATURE_PROBLEM_DETAILS is set to true.
|
Don't you want this to be the other way round @NSeydoux ? If you demand that it's set to true where the feature exists you are going to need to carry this feature flag for ever more and callers will always have to set it. ofc this is tempered by the opposing force that we should not break existing code when adding something. |
Contributor
Author
|
Exactly, I went with the non-breaking approach. When we stop supporting versions that do not have the problem details feature, we can remove the check altogether. |
davidboweninrupt
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end-to-end tests need to run against older supported versions of ESS, not all of which support problem details.
By default, only the response status and title are checked, which are provided by default against any HTTP response. Problem details and instance are only checked if the environment variable E2E_TEST_FEATURE_PROBLEM_DETAILS is set to true.