Add args as an attribute to output of ard_strata() and ard_pairwise()#545
Open
alanahjonas95 wants to merge 5 commits intoinsightsengineering:mainfrom
Open
Add args as an attribute to output of ard_strata() and ard_pairwise()#545alanahjonas95 wants to merge 5 commits intoinsightsengineering:mainfrom
ard_strata() and ard_pairwise()#545alanahjonas95 wants to merge 5 commits intoinsightsengineering:mainfrom
Conversation
ard_strata() and ard_pairwise()ard_strata() and ard_pairwise()
Melkiades
reviewed
Feb 28, 2026
Contributor
Melkiades
left a comment
There was a problem hiding this comment.
For me this looks good! Thanks @alanahjonas95
@ddsjoberg to you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Style this entry in a way that can be copied directly into
NEWS.md. (#, @)ard_strata()andard_pairwise()contain anargsattribute to retain information about input arguments. (Should other functions pass down arguments via theargsattribute? #483, @alanahjonas95)Provide more detail here as needed.
Reference GitHub issue associated with pull request. e.g., 'closes #'
resolves #483
I've updated two fuctions wanted to confirm these are ok before doing others
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).Optional Reverse Dependency Checks:
Install
checkedwithpak::pak("Genentech/checked")orpak::pak("checked")