Skip to content

Comments

Fix failing integration test#258

Merged
edelarua merged 3 commits intomainfrom
fix_integration_test
Feb 7, 2025
Merged

Fix failing integration test#258
edelarua merged 3 commits intomainfrom
fix_integration_test

Conversation

@edelarua
Copy link
Contributor

@edelarua edelarua commented Feb 7, 2025

What changes are proposed in this pull request?

  • Fix failing integration test for ard_categorical_max().
[ FAIL 2 | WARN 0 | SKIP 0 | PASS 700 ]
  
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-ard_categorical_max.R:54:3'): ard_categorical_max() works with default settings ──
  `res` (`actual`) not equal to res2[-c(28:45), ] (`expected`).
  ── Failure ('test-ard_categorical_max.R:191:3'): ard_categorical_max() works with pre-ordered factor variables ──
  `res` (`actual`) not equal to res3[-c(1:18), ] (`expected`).

Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@edelarua edelarua added the sme label Feb 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Unit Tests Summary

  1 files  170 suites   1m 11s ⏱️
168 tests 129 ✅ 39 💤 0 ❌
595 runs  542 ✅ 53 💤 0 ❌

Results for commit 1092da9.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Unit Tests Summary

  1 files  170 suites   1m 11s ⏱️
168 tests 129 ✅ 39 💤 0 ❌
595 runs  542 ✅ 53 💤 0 ❌

Results for commit 3907cc6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_attributes.survey.design 💚 $1.74$ $-1.71$ $0$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_aod_wald_test 💔 $0.29$ $+1.25$ ard_aod_wald_test_works
ard_attributes.survey.design 💚 $1.74$ $-1.71$ ard_attributes.survey.design_works
ard_categorical_max 💚 $2.92$ $-1.83$ ard_categorical_max_works_with_default_settings
ard_continuous.survey.design 💔 $18.70$ $+3.74$ unstratified_ard_continuous.survey.design_works
ard_survival_survfit 💚 $2.76$ $-1.07$ ard_survival_survfit_works_with_times_provided
construction_helpers 💚 $2.33$ $-1.90$ construct_model_works
proportion_ci 💚 $1.60$ $-1.45$ check_the_proportion_ci__functions_work

Results for commit de5d613

♻️ This comment has been updated with latest results.

@ddsjoberg
Copy link
Collaborator

Thank you @edelarua for updating!! Could you please replace the entire test-coverage with the updated one from usethis? They've made a handful of other small changes in addition to addressing the deprecation. usethis::use_github_action("test-coverage")

@edelarua
Copy link
Contributor Author

edelarua commented Feb 7, 2025

Thank you @edelarua for updating!! Could you please replace the entire test-coverage with the updated one from usethis? They've made a handful of other small changes in addition to addressing the deprecation. usethis::use_github_action("test-coverage")

Done!

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@edelarua edelarua merged commit 1d23807 into main Feb 7, 2025
30 checks passed
@edelarua edelarua deleted the fix_integration_test branch February 7, 2025 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants