Skip to content

Comments

Removed spelling from DESCRIPTION, similar to what was done in cards#259

Merged
ddsjoberg merged 3 commits intoinsightsengineering:mainfrom
kimjj93:remove_spelling_dependency
Feb 9, 2025
Merged

Removed spelling from DESCRIPTION, similar to what was done in cards#259
ddsjoberg merged 3 commits intoinsightsengineering:mainfrom
kimjj93:remove_spelling_dependency

Conversation

@kimjj93
Copy link
Collaborator

@kimjj93 kimjj93 commented Feb 8, 2025

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (ddsjoberg)[https://github.com/ddsjoberg]
@kimjj93
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Collaborator Author

@kimjj93 kimjj93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @kimjj93 !!!

@ddsjoberg ddsjoberg merged commit 9254044 into insightsengineering:main Feb 9, 2025
30 of 32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
@kimjj93 kimjj93 deleted the remove_spelling_dependency branch February 9, 2025 23:34
@kimjj93 kimjj93 restored the remove_spelling_dependency branch February 10, 2025 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants