Skip to content

Comments

Fix in ard_survival_survfit.data.frame() type conversion#298

Merged
ddsjoberg merged 4 commits intomainfrom
survfit-type-conversion
May 27, 2025
Merged

Fix in ard_survival_survfit.data.frame() type conversion#298
ddsjoberg merged 4 commits intomainfrom
survfit-type-conversion

Conversation

@ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

  • Fix in ard_survival_survfit.data.frame() method where the stratifying variable was not correctly converted back to its original type.

Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_categorical_max 💚 $3.04$ $-1.83$ ard_categorical_max_works_with_default_settings
ard_continuous.survey.design 💔 $8.08$ $+10.08$ unstratified_ard_continuous.survey.design_works
ard_regression 💚 $3.82$ $-1.30$ ard_regression_works
ard_survival_survfit 💚 $3.49$ $-1.37$ ard_survival_survfit_works_with_times_provided
construction_helpers 💚 $2.27$ $-1.84$ construct_model_works
proportion_ci 💚 $1.74$ $-1.58$ check_the_proportion_ci__functions_work

Results for commit fec5f02

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files  181 suites   1m 17s ⏱️
179 tests 179 ✅ 0 💤 0 ❌
751 runs  751 ✅ 0 💤 0 ❌

Results for commit b28218f.

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files  181 suites   1m 15s ⏱️
179 tests 140 ✅ 39 💤 0 ❌
611 runs  552 ✅ 59 💤 0 ❌

Results for commit b28218f.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                                Stmts    Miss  Cover    Missing
------------------------------------  -------  ------  -------  -----------------------------------
R/add_total_n.survey.design.R              12       0  100.00%
R/ard_aod_wald_test.R                      77       2  97.40%   93, 96
R/ard_attributes.survey.design.R            2       0  100.00%
R/ard_car_anova.R                          45       2  95.56%   62, 65
R/ard_car_vif.R                            62       1  98.39%   87
R/ard_categorical_ci.R                    320       1  99.69%   93
R/ard_categorical_ci.survey.design.R      129       1  99.22%   180
R/ard_categorical_max.R                    40       1  97.50%   58
R/ard_categorical.survey.design.R         393       8  97.96%   77, 228-231, 275, 517, 531
R/ard_continuous_ci.R                      28       1  96.43%   38
R/ard_continuous_ci.survey.design.R       138       0  100.00%
R/ard_continuous.survey.design.R          277      14  94.95%   86, 177, 187, 338, 369-370, 421-429
R/ard_dichotomous.survey.design.R          73       3  95.89%   51, 156, 161
R/ard_effectsize_cohens_d.R               103       2  98.06%   69, 122
R/ard_effectsize_hedges_g.R                91       2  97.80%   68, 120
R/ard_emmeans_mean_difference.R            88       0  100.00%
R/ard_incidence_rate.R                    104       0  100.00%
R/ard_missing.survey.design.R              82       1  98.78%   52
R/ard_regression_basic.R                   31       1  96.77%   61
R/ard_regression.R                         87       0  100.00%
R/ard_smd_smd.R                            69       5  92.75%   57, 83-86
R/ard_stats_anova.R                        95       0  100.00%
R/ard_stats_aov.R                          46       0  100.00%
R/ard_stats_chisq_test.R                   40       1  97.50%   39
R/ard_stats_fisher_test.R                  43       1  97.67%   42
R/ard_stats_kruskal_test.R                 36       1  97.22%   38
R/ard_stats_mantelhaen_test.R              67       1  98.51%   45
R/ard_stats_mcnemar_test.R                 80       2  97.50%   63, 106
R/ard_stats_mood_test.R                    49       1  97.96%   45
R/ard_stats_oneway_test.R                  39       0  100.00%
R/ard_stats_poisson_test.R                 76       1  98.68%   59
R/ard_stats_prop_test.R                    85       1  98.82%   43
R/ard_stats_t_test_onesample.R             41       0  100.00%
R/ard_stats_t_test.R                      112       2  98.21%   65, 111
R/ard_stats_wilcox_test_onesample.R        42       0  100.00%
R/ard_stats_wilcox_test.R                  99       2  97.98%   65, 117
R/ard_survey_svychisq.R                    38       1  97.37%   44
R/ard_survey_svyranktest.R                 54       1  98.15%   44
R/ard_survey_svyttest.R                    53       1  98.11%   42
R/ard_survival_survdiff.R                  89       0  100.00%
R/ard_survival_survfit_diff.R              76       0  100.00%
R/ard_survival_survfit.R                  236       5  97.88%   234-238
R/construction_helpers.R                  106      10  90.57%   160-175, 189, 248
R/proportion_ci.R                         203       1  99.51%   463
TOTAL                                    4056      77  98.10%

Diff against main

Filename                            Stmts    Miss  Cover
--------------------------------  -------  ------  -------
R/ard_continuous.survey.design.R       +3       0  +0.06%
TOTAL                                  +3       0  +0.00%

Results for commit: b28218f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@ddsjoberg ddsjoberg merged commit d2235d7 into main May 27, 2025
33 checks passed
@ddsjoberg ddsjoberg deleted the survfit-type-conversion branch May 27, 2025 22:47
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant