Skip to content

Comments

Adding ard_smd()#65

Merged
ddsjoberg merged 4 commits intomainfrom
ard_smd
Mar 6, 2024
Merged

Adding ard_smd()#65
ddsjoberg merged 4 commits intomainfrom
ard_smd

Conversation

@ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Mar 3, 2024

What changes are proposed in this pull request?

  • Adding ard_smd()

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #4


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (cd67f80) to head (3d5fd06).
Report is 1 commits behind head on main.

❗ Current head 3d5fd06 differs from pull request most recent head ed89c36. Consider uploading reports for the commit ed89c36 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   99.72%   99.73%   +0.01%     
==========================================
  Files          14       15       +1     
  Lines         720      754      +34     
==========================================
+ Hits          718      752      +34     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------
R/ard_chisqtest.R              31       0  100.00%
R/ard_cohens_d.R               73       0  100.00%
R/ard_fishertest.R             33       0  100.00%
R/ard_hedges_g.R               60       0  100.00%
R/ard_kruskaltest.R            27       0  100.00%
R/ard_mcnemartest.R            41       0  100.00%
R/ard_moodtest.R               40       0  100.00%
R/ard_proportion_ci.R          40       5  87.50%   63-67
R/ard_proptest.R               71       0  100.00%
R/ard_regression_basic.R       14       1  92.86%   44
R/ard_regression.R             49       0  100.00%
R/ard_smd.R                    40       0  100.00%
R/ard_ttest.R                  78       0  100.00%
R/ard_wilcoxtest.R             83       0  100.00%
R/proportion_ci.R             188      28  85.11%   248, 251, 260-265, 273, 288, 388-411
TOTAL                         868      34  96.08%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  --------
R/ard_smd.R      +40       0  +100.00%
TOTAL            +40       0  +0.19%

Results for commit: ed89c36

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Unit Tests Summary

 1 files  24 suites   4s ⏱️
23 tests 19 ✅  4 💤 0 ❌
63 runs  49 ✅ 14 💤 0 ❌

Results for commit ed89c36.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_smd 👶 $+0.00$ $+4$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_smd 👶 $+0.01$ ard_proptest_error_messaging
ard_smd 👶 $+0.16$ ard_smd_works

Results for commit 3d5fd06

♻️ This comment has been updated with latest results.

Copy link
Contributor

@zdz2101 zdz2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ddsjoberg ddsjoberg merged commit cc286b9 into main Mar 6, 2024
@ddsjoberg ddsjoberg deleted the ard_smd branch March 6, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ARD for differences

3 participants