Skip to content

Comments

Adding ard_car_anova()#67

Merged
ddsjoberg merged 13 commits intomainfrom
car-Anova
Mar 6, 2024
Merged

Adding ard_car_anova()#67
ddsjoberg merged 13 commits intomainfrom
car-Anova

Conversation

@ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Mar 3, 2024

What changes are proposed in this pull request?

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #3


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.47%. Comparing base (cd67f80) to head (c300aa3).
Report is 1 commits behind head on main.

❗ Current head c300aa3 differs from pull request most recent head e906ba6. Consider uploading reports for the commit e906ba6 to get more accurate results

Files Patch % Lines
R/ard_car_anova.R 94.28% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   99.72%   99.47%   -0.26%     
==========================================
  Files          14       15       +1     
  Lines         720      755      +35     
==========================================
+ Hits          718      751      +33     
- Misses          2        4       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
@ddsjoberg ddsjoberg marked this pull request as ready for review March 3, 2024 23:35
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Unit Tests Summary

 1 files  26 suites   4s ⏱️
25 tests 20 ✅  5 💤 0 ❌
67 runs  51 ✅ 16 💤 0 ❌

Results for commit 5ed5d2a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------
R/ard_car_anova.R              41       2  95.12%   57, 60
R/ard_chisqtest.R              31       0  100.00%
R/ard_cohens_d.R               73       0  100.00%
R/ard_fishertest.R             33       0  100.00%
R/ard_hedges_g.R               60       0  100.00%
R/ard_kruskaltest.R            27       0  100.00%
R/ard_mcnemartest.R            41       0  100.00%
R/ard_moodtest.R               40       0  100.00%
R/ard_proportion_ci.R          40       5  87.50%   63-67
R/ard_proptest.R               71       0  100.00%
R/ard_regression_basic.R       14       1  92.86%   44
R/ard_regression.R             49       0  100.00%
R/ard_smd.R                    40       0  100.00%
R/ard_ttest.R                  78       0  100.00%
R/ard_wilcoxtest.R             83       0  100.00%
R/proportion_ci.R             188      28  85.11%   248, 251, 260-265, 273, 288, 388-411
TOTAL                         909      36  96.04%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/ard_car_anova.R      +41      +2  +95.12%
TOTAL                  +41      +2  -0.04%

Results for commit: 5ed5d2a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_car_anova 👶 $+0.02$ $+1$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_car_anova 👶 $+0.02$ ard_car_anova_messaging
ard_car_anova 👶 $+0.83$ ard_car_anova_works

Results for commit bd3b0e0

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg merged commit c849ad4 into main Mar 6, 2024
@ddsjoberg ddsjoberg deleted the car-Anova branch March 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ARD for car::Anova() output

3 participants