Skip to content

Comments

ard_smd() for weighted data#74

Merged
ddsjoberg merged 7 commits intomainfrom
weighted-ard_smd
Mar 15, 2024
Merged

ard_smd() for weighted data#74
ddsjoberg merged 7 commits intomainfrom
weighted-ard_smd

Conversation

@ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Mar 8, 2024

What changes are proposed in this pull request?

  • Updated ard_smd() to work with weighted data from the survey package.

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #73


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------
R/ard_car_anova.R              41       2  95.12%   57, 60
R/ard_chisqtest.R              31       0  100.00%
R/ard_cohens_d.R               87       2  97.70%   64, 107
R/ard_fishertest.R             33       0  100.00%
R/ard_hedges_g.R               75       2  97.33%   63, 106
R/ard_kruskaltest.R            27       0  100.00%
R/ard_mcnemartest.R            41       0  100.00%
R/ard_moodtest.R               47       1  97.87%   44
R/ard_proportion_ci.R          40       5  87.50%   63-67
R/ard_proptest.R               71       0  100.00%
R/ard_regression_basic.R       14       1  92.86%   44
R/ard_regression.R             49       0  100.00%
R/ard_smd.R                    47       0  100.00%
R/ard_svychisq.R               36       1  97.22%   42
R/ard_svycontinuous.R         192       2  98.96%   166, 176
R/ard_svyttest.R               49       0  100.00%
R/ard_ttest.R                  92       2  97.83%   61, 103
R/ard_vif.R                    58       2  96.55%   46, 80
R/ard_wilcoxtest.R             97       2  97.94%   61, 103
R/proportion_ci.R             188      28  85.11%   275, 278, 287-292, 300, 315, 415-438
TOTAL                        1315      50  96.20%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  --------
R/ard_smd.R       +7       0  +100.00%
TOTAL             +7       0  +0.02%

Results for commit: 053730e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Unit Tests Summary

  1 files  40 suites   6s ⏱️
 39 tests 29 ✅ 10 💤 0 ❌
115 runs  92 ✅ 23 💤 0 ❌

Results for commit 053730e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_smd 👶 $+0.00$ ard_smd_works_with_survey_data

Results for commit 9d31616

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (eb2b89f) to head (c749fb5).
Report is 1 commits behind head on main.

❗ Current head c749fb5 differs from pull request most recent head c4eefe6. Consider uploading reports for the commit c4eefe6 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   99.17%   99.18%           
=======================================
  Files          17       17           
  Lines         848      854    +6     
=======================================
+ Hits          841      847    +6     
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zdz2101 zdz2101 self-requested a review March 15, 2024 20:00
Copy link
Contributor

@zdz2101 zdz2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddsjoberg ddsjoberg merged commit 3665fee into main Mar 15, 2024
@ddsjoberg ddsjoberg deleted the weighted-ard_smd branch March 15, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ard_smd() to work with survey/weighted data

3 participants