Skip to content

Readable code poc@main#778

Merged
BFalquet merged 22 commits intomainfrom
readable_code_poc@main
Oct 11, 2024
Merged

Readable code poc@main#778
BFalquet merged 22 commits intomainfrom
readable_code_poc@main

Conversation

@BFalquet
Copy link
Copy Markdown
Contributor

@BFalquet BFalquet commented Sep 16, 2024

POC for readable code.

the unwrap arguments in run allow the display of the function of the chevron_tlg object.

sibling PR in dunlin: insightsengineering/dunlin#162

thank you for the review

@BFalquet BFalquet marked this pull request as ready for review October 4, 2024 07:10
@BFalquet BFalquet requested a review from clarkliming as a code owner October 4, 2024 07:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Unit Tests Summary

  1 files   58 suites   3m 18s ⏱️
291 tests 290 ✅ 1 💤 0 ❌
667 runs  658 ✅ 9 💤 0 ❌

Results for commit a5803e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
chevron_tlg-methods 💔 $8.04$ $+1.78$ $+5$ $0$ $0$ $0$
unwrap 👶 $+0.16$ $+9$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
chevron_tlg-methods 👶 $+0.32$ run_print_internal_functions_when_unwrap_is_TRUE
chevron_tlg-methods 👶 $+1.18$ run_print_internal_functions_when_unwrap_is_TRUE_and_standard_chevron_tlg_has_no_layout
chevron_tlg-methods 👶 $+0.03$ run_print_internal_functions_when_unwrap_is_TRUE_and_the_chevron_tlg_object_is_customized
chevron_tlg-methods 👶 $+0.03$ run_print_main_and_postprocessing_functions_when_unwrap_is_TRUE_and_auto_pre_is_FALSE
unwrap 👶 $+0.03$ unwrap_layout_works_as_expected_on_custom_function_with_overwritten_layout_function
unwrap 👶 $+0.04$ unwrap_layout_works_as_expected_with_a_custom_function_with_layout_function
unwrap 👶 $+0.01$ unwrap_layout_works_as_expected_with_a_custom_function_without_layout_function
unwrap 👶 $+0.04$ unwrap_layout_works_as_expected_with_multiple_layout_function
unwrap 👶 $+0.01$ unwrap_layout_works_as_expected_with_standard_chevron_g_main_function
unwrap 👶 $+0.01$ unwrap_layout_works_as_expected_with_standard_chevron_l_main_function
unwrap 👶 $+0.04$ unwrap_layout_works_as_expected_with_standard_chevron_t_main_function

Results for commit 14a17bd

♻️ This comment has been updated with latest results.

BFalquet added a commit to insightsengineering/dunlin that referenced this pull request Oct 10, 2024
add a `verbose` argument to filter and reformat functions to print
details of the operations
move the `get_arg` function to dunlin:

sibling PR in chevron
insightsengineering/chevron#778

thank you for the review
Copy link
Copy Markdown
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Although I am not 100% sure if the printed function would help

@BFalquet BFalquet merged commit 9653864 into main Oct 11, 2024
@BFalquet BFalquet deleted the readable_code_poc@main branch October 11, 2024 12:29
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants