Conversation
Contributor
Unit Tests Summary 1 files 58 suites 3m 18s ⏱️ Results for commit a5803e9. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 14a17bd ♻️ This comment has been updated with latest results. |
Signed-off-by: b_falquet <64274616+BFalquet@users.noreply.github.com>
BFalquet
added a commit
to insightsengineering/dunlin
that referenced
this pull request
Oct 10, 2024
add a `verbose` argument to filter and reformat functions to print details of the operations move the `get_arg` function to dunlin: sibling PR in chevron insightsengineering/chevron#778 thank you for the review
clarkliming
approved these changes
Oct 11, 2024
Contributor
clarkliming
left a comment
There was a problem hiding this comment.
looks good to me. Although I am not 100% sure if the printed function would help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC for readable code.
the
unwraparguments in run allow the display of the function of thechevron_tlgobject.sibling PR in dunlin: insightsengineering/dunlin#162
thank you for the review