Skip to content

Remove bold formatting from Roche theme#121

Merged
Melkiades merged 1 commit intomainfrom
120-theme_no_bold_headers
Sep 17, 2025
Merged

Remove bold formatting from Roche theme#121
Melkiades merged 1 commit intomainfrom
120-theme_no_bold_headers

Conversation

@edelarua
Copy link
Copy Markdown
Contributor

@edelarua edelarua commented Sep 15, 2025

What changes are proposed in this pull request?

Closes #120


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@edelarua edelarua added the sme label Sep 15, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025

Unit Tests Summary

  1 files   63 suites   1m 30s ⏱️
 63 tests  63 ✅ 0 💤 0 ❌
157 runs  157 ✅ 0 💤 0 ❌

Results for commit 8b20377.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tbl_baseline_chg 💔 $14.30$ $+1.03$ tbl_baseline_chg_works
tbl_hierarchical_rate_by_grade 💚 $8.57$ $-3.20$ tbl_hierarchical_rate_by_grade_works

Results for commit 8ff9414

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ---------
R/add_blank_rows.R                        63       0  100.00%
R/add_hierarchical_count_row.R            33       0  100.00%
R/crane-package.R                          2       2  0.00%    17-18
R/deprecated.R                             6       6  0.00%    15-21
R/label_roche.R                           63       0  100.00%
R/modify_header_rm_md.R                   18       2  88.89%   35-36
R/modify_zero_recode.R                    13       0  100.00%
R/tbl_baseline_chg.R                     184       0  100.00%
R/tbl_hierarchical_rate_and_count.R      148       0  100.00%
R/tbl_hierarchical_rate_by_grade.R       271       3  98.89%   162-164
R/tbl_listing.R                           35       0  100.00%
R/tbl_roche_summary.R                     59       0  100.00%
R/tbl_shift.R                            115       0  100.00%
R/tbl_survfit_quantiles.R                132       1  99.24%   295
R/tbl_survfit_times.R                     92       0  100.00%
R/theme_gtsummary_roche.R                 73       0  100.00%
R/utils.R                                  5       0  100.00%
TOTAL                                   1312      14  98.93%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/theme_gtsummary_roche.R       -1       0  +100.00%
TOTAL                           -1       0  -0.00%

Results for commit: 8b20377

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@edelarua
Copy link
Copy Markdown
Contributor Author

@Melkiades I believe you added the bold header formatting initally. Can you confirm that this PR successfully removes it? Thanks!!

@edelarua edelarua requested a review from Melkiades September 15, 2025 20:30
Copy link
Copy Markdown
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emily!! This all that is needed to remove header bolding.

@Melkiades Melkiades merged commit 27468a5 into main Sep 17, 2025
34 checks passed
@Melkiades Melkiades deleted the 120-theme_no_bold_headers branch September 17, 2025 11:57
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove bold text in column labels as part of default Roche theme

2 participants