Skip to content

Remove type casting to factor when few values (numeric)#124

Merged
ddsjoberg merged 9 commits intomainfrom
79_stochstic_stop@main
Oct 3, 2025
Merged

Remove type casting to factor when few values (numeric)#124
ddsjoberg merged 9 commits intomainfrom
79_stochstic_stop@main

Conversation

@Melkiades
Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

  • Removed type casting to factor when few values (numeric).

#79


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 29, 2025

Unit Tests Summary

  1 files   66 suites   1m 34s ⏱️
 66 tests  66 ✅ 0 💤 0 ❌
163 runs  163 ✅ 0 💤 0 ❌

Results for commit 050de08.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 29, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tbl_hierarchical_rate_by_grade 💚 $7.65$ $-2.58$ tbl_hierarchical_rate_by_grade_works
theme_gtsummary_roche 👶 $+0.00$ with_assign_summary_type_arg_cat_threshold_0L_each_data_type_is_always_mapped_as_it_is

Results for commit 93c66ba

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 29, 2025

badge

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ---------
R/add_blank_rows.R                        63       0  100.00%
R/add_hierarchical_count_row.R            33       0  100.00%
R/crane-package.R                          2       2  0.00%    17-18
R/deprecated.R                             6       6  0.00%    15-21
R/label_roche.R                           86       4  95.35%   174-177
R/modify_header_rm_md.R                   18       2  88.89%   35-36
R/modify_zero_recode.R                    13       0  100.00%
R/tbl_baseline_chg.R                     184       0  100.00%
R/tbl_hierarchical_rate_and_count.R      148       0  100.00%
R/tbl_hierarchical_rate_by_grade.R       271       3  98.89%   162-164
R/tbl_listing.R                           35       0  100.00%
R/tbl_null_report.R                        9       0  100.00%
R/tbl_roche_summary.R                     60       0  100.00%
R/tbl_shift.R                            115       0  100.00%
R/tbl_survfit_quantiles.R                132       1  99.24%   295
R/tbl_survfit_times.R                     92       0  100.00%
R/theme_gtsummary_roche.R                 74       0  100.00%
R/utils.R                                  5       0  100.00%
TOTAL                                   1346      18  98.66%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/theme_gtsummary_roche.R       +1       0  +100.00%
TOTAL                           +1       0  +0.00%

Results for commit: 050de08

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Comment thread DESCRIPTION
pharmaverseadam,
testthat (>= 3.0.0),
withr (>= 3.0.1)
Remotes: ddsjoberg/gtsummary
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot! apologies

Copy link
Copy Markdown
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@ddsjoberg ddsjoberg merged commit ee1554b into main Oct 3, 2025
34 checks passed
@ddsjoberg ddsjoberg deleted the 79_stochstic_stop@main branch October 3, 2025 15:22
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants