faster sorting

[Melkiades]

What changes are proposed in this pull request?

• Improved sorting for tbl_roche_summary().

Note that the PR was originally connected to issue #12 that has already ~98% coverage
#26

---

Pre-review Checklist (if item does not apply, mark is as complete)

• All GitHub Action workflows pass with a ✅
• PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
• If a bug was fixed, a unit test was added.
• Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
• Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

• If a bug was fixed, a unit test was added.
• Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
• Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

• Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
• All GitHub Action workflows pass with a ✅
• Approve Pull Request
• Merge the PR. Please use "Squash and merge" or "Rebase and merge".

[github-actions]

Unit Tests Summary

  1 files   65 suites   1m 38s ⏱️
 65 tests  65 ✅ 0 💤 0 ❌
162 runs  162 ✅ 0 💤 0 ❌

Results for commit e31ba41.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
modify_zero_recode	💔	$0.03$	$+1.05$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
modify_zero_recode	💔	$0.03$	$+1.05$	modify_zero_recode_works
tbl_hierarchical_rate_by_grade	💔	$8.15$	$+1.94$	tbl_hierarchical_rate_by_grade_works

Results for commit 4864c5c

♻️ This comment has been updated with latest results.

[Melkiades]

Hi @ayogasekaram, I think you worked on this function, right? tbl_baseline_chg(). I think an extra sorting of visit should be added as now it is not done by tbl_roche_summary() as before. Could you take a look please? Thanks!!

[github-actions]

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ---------
R/add_blank_rows.R                        63       0  100.00%
R/add_hierarchical_count_row.R            33       0  100.00%
R/crane-package.R                          2       2  0.00%    17-18
R/deprecated.R                             6       6  0.00%    15-21
R/label_roche.R                           86       4  95.35%   174-177
R/modify_header_rm_md.R                   18       2  88.89%   35-36
R/modify_zero_recode.R                    13       0  100.00%
R/tbl_baseline_chg.R                     184       0  100.00%
R/tbl_hierarchical_rate_and_count.R      148       0  100.00%
R/tbl_hierarchical_rate_by_grade.R       271       3  98.89%   162-164
R/tbl_listing.R                           35       0  100.00%
R/tbl_null_report.R                        9       0  100.00%
R/tbl_roche_summary.R                     60       0  100.00%
R/tbl_shift.R                            115       0  100.00%
R/tbl_survfit_quantiles.R                132       1  99.24%   295
R/tbl_survfit_times.R                     92       0  100.00%
R/theme_gtsummary_roche.R                 73       0  100.00%
R/utils.R                                  5       0  100.00%
TOTAL                                   1345      18  98.66%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/tbl_roche_summary.R       +1       0  +100.00%
TOTAL                       +1       0  +0.00%

Results for commit: e31ba41

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[Melkiades]

thank you @ayogasekaram!! very nice solution :))

[ddsjoberg]

Thanks !!! Looks great!