Skip to content

Listing key columns info not repeated when vertically spanning multiple pages #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edelarua merged 4 commits into from
Feb 5, 2025
Merged

Listing key columns info not repeated when vertically spanning multiple pages #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea6d27f
Fix bug
edelarua Feb 5, 2025
42d0c44
Update NEWS
edelarua Feb 5, 2025
f69c2ba
Add project ID - required for R 4.4.2+
edelarua Feb 5, 2025
5de4300
Fix tests
edelarua Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## formatters 0.5.10.9000
* Fixed a bug in `mform_handle_newlines` that caused string matrix column names to be removed. This prevented paginated listing key column info from being repeated when vertically spanning multiple pages.

## formatters 0.5.10
* Fixed a bug in `mf_update_cinfo` causing an error when `export_as_txt` was applied to empty listings.
Expand Down
1 change: 1 addition & 0 deletions R/matrix_form.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ mform_handle_newlines <- function(matform) {
),
expand_mat_rows(strmat[-1 * hdr_inds, , drop = FALSE], row_nlines[-hdr_inds])
)
colnames(newstrmat) <- colnames(strmat)

newfrmmat <- rbind(
expand_mat_rows(
Expand Down
1 change: 1 addition & 0 deletions formatters.Rproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Version: 1.0
ProjectId: 91d83c00-f38c-4245-80dc-783a2cfe8487

RestoreWorkspace: Default
SaveWorkspace: Default
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-pagination.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ test_that("pagination works", {
dfmf2 <- mform_handle_newlines(dfmf2)
expect_identical(
dfmf2$strings[1:2, 1:2],
matrix(c("", "tleft mats", "m", "pg"), nrow = 2, ncol = 2)
matrix(c("", "tleft mats", "m", "pg"), nrow = 2, ncol = 2, dimnames = list(NULL, c("rnms", "mpg")))
)

## https://github.com/insightsengineering/formatters/issues/77
Expand Down
Loading