Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Feb 21, 2025

Part of https://github.com/insightsengineering/coredev-tasks/issues/609

From now on, we will provide development dependencies in

Remotes: repo/project@branch

format, so it's explicitly visible in the DESCRIPTION file and can be handled by pak::install, renv::install and remotes::install.

With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.

@m7pr m7pr added the core label Feb 21, 2025
@m7pr m7pr requested review from llrs-roche and shajoezhu February 21, 2025 09:47
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@m7pr
Copy link
Contributor Author

m7pr commented Feb 21, 2025

I have read the CLA Document and I hereby sign the CLA

@m7pr
Copy link
Contributor Author

m7pr commented Feb 21, 2025

recheck

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @m7pr

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Unit Tests Summary

  1 files  111 suites   3m 12s ⏱️
245 tests 214 ✅  31 💤 0 ❌
479 runs  236 ✅ 243 💤 0 ❌

Results for commit da602de.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $13.79$ $-2.27$ $-9$ $+6$ $0$ $0$
table_aet03 💚 $4.73$ $-3.20$ $-4$ $+1$ $0$ $0$
table_aet04 💚 $12.08$ $-6.04$ $-14$ $+8$ $0$ $0$
table_pkct01 💚 $3.24$ $-1.68$ $-6$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
pagination_table 💚 $3.51$ $-2.02$ Pagination_works_for_page_types
table_aet03 💚 $4.73$ $-3.20$ AET03_variant_1_is_produced_correctly
table_pkct01 💚 $2.68$ $-1.47$ Specific_PKCT01_features_are_present

Results for commit 24d913c

♻️ This comment has been updated with latest results.

@m7pr m7pr merged commit ec47620 into main Feb 21, 2025
27 checks passed
@m7pr m7pr deleted the remove_lookups branch February 21, 2025 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants