Skip to content

Conversation

@nikolas-burkoff
Copy link
Contributor

withr is now used in the tests

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Unit Tests Summary

       1 files       27 suites   41s ⏱️
   320 tests    320 ✔️ 0 💤 0
1 102 runs  1 102 ✔️ 0 💤 0

Results for commit 361ba28.

@pawelru
Copy link
Contributor

pawelru commented Oct 4, 2022

I am curious - where did you get a warning?
Checked internal integration tests - we fail on build and not enter check
Checked CI - this is the last results from main - https://github.com/insightsengineering/teal.data/actions/runs/3159056253/jobs/5141809041 - no warrnings.

@nikolas-burkoff
Copy link
Contributor Author

nikolas-burkoff commented Oct 4, 2022

I am curious - where did you get a warning?

When I ran R CMD CHECK in RStudio -> it is needed maybe our checks are different ...

withr::with_options(list("teal.bs_theme" = bslib::bs_theme(version = "5")), {

@pawelru
Copy link
Contributor

pawelru commented Oct 4, 2022

OK I see it now and it only appeared from within RStudio. That's a little bit strange...

@nikolas-burkoff nikolas-burkoff merged commit e91bd58 into main Oct 4, 2022
@nikolas-burkoff nikolas-burkoff deleted the fixes@main branch October 4, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants