Skip to content

Conversation

@mhallal1
Copy link
Contributor

@mhallal1 mhallal1 commented Nov 9, 2022

related to insightsengineering/teal#751

remove datasets hashing and transfer it to teal.

@mhallal1 mhallal1 added the core label Nov 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/as_cdisc.R                                39       4  89.74%   107-110
R/Callable.R                                45       0  100.00%
R/CallableCode.R                            36       2  94.44%   26, 63
R/CallableFunction.R                        88       3  96.59%   160-162
R/CallablePythonCode.R                      58      58  0.00%    21-223
R/CDISCTealData.R                           79      12  84.81%   41, 47-50, 55, 128, 131, 134, 267-269
R/CDISCTealDataConnector.R                  20       3  85.00%   31, 36, 49
R/CDISCTealDataset.R                        46      11  76.09%   108-115, 208-210
R/CDISCTealDatasetConnector.R               26       1  96.15%   116
R/CodeClass.R                              111       1  99.10%   157
R/data_label.R                              32       9  71.88%   35-39, 58-61, 101
R/deep_clone_r6.R                            9       0  100.00%
R/get_attrs.R                                2       2  0.00%    12-47
R/get_code.R                               173      21  87.86%   87, 140-143, 196-197, 201, 207-208, 212, 266, 297, 333, 337, 372, 381-385
R/get_dataname.R                             4       0  100.00%
R/get_dataset_label.R                        3       0  100.00%
R/get_dataset.R                             13       8  38.46%   41, 58, 85-91
R/get_datasets.R                            10       5  50.00%   86, 108-112
R/get_key_duplicates.R                      37       7  81.08%   42-48, 55-56
R/get_keys.R                                15       7  53.33%   72-73, 130-150
R/get_raw_data.R                            24      11  54.17%   161-174
R/include_css_js.R                           9       1  88.89%   20
R/is_pulled.R                                4       0  100.00%
R/JoinKeys.R                               128       4  96.88%   219, 282-321
R/load_dataset.R                            25      18  28.00%   60-65, 89-222
R/MAETealDataset.R                         138      57  58.70%   57, 119, 157-212, 228-233, 240-249, 286, 327-343
R/mutate_dataset.R                          18       0  100.00%
R/set_args.R                                10       5  50.00%   42-46
R/teal_data.R                               21       3  85.71%   101-103
R/TealData.R                               273     117  57.14%   87, 99, 236, 248-317, 331, 334, 390-397, 428-433, 435, 437-442, 444, 461-506
R/TealDataAbstract.R                       231      13  94.37%   86-89, 214-217, 428, 453-457, 479, 485
R/TealDataConnection.R                     297     180  39.39%   58-59, 64, 67, 70, 106-163, 183, 186-188, 194-200, 205-207, 233, 238, 254-277, 287, 300, 321, 325-330, 333-336, 358-360, 364-371, 374-377, 392-406, 425-426, 446-517, 535-543, 545, 549-564, 567-570, 602, 608-612, 626, 661-663, 672-674
R/TealDataConnector.R                      196     102  47.96%   167, 179, 183, 196, 199-208, 210, 218-227, 310-314, 372-477
R/TealDataset.R                            384      23  94.01%   146-156, 431-435, 491-500, 552
R/TealDatasetConnector_constructors.R      300      53  82.33%   176-212, 262, 830-835, 1033-1109
R/TealDatasetConnector.R                   342      91  73.39%   122, 179, 248, 262, 267, 281, 473, 496-535, 566, 581-611, 701, 711, 720-727, 740, 755-782
R/to_relational_data.R                      54       7  87.04%   35-36, 40, 99, 106, 112, 127
R/topological_sort.R                        32       4  87.50%   53-56
R/utils.R                                   56       9  83.93%   22-23, 27, 76-83
R/validate_data_args.R                      32       0  100.00%
R/zzz.R                                      6       6  0.00%    4-12
TOTAL                                     3426     858  74.96%

Diff against main

Filename              Stmts  Miss    Cover
------------------  -------  ------  -------
R/MAETealDataset.R       +1  -       +0.30%
R/TealDataset.R          +9  -       +0.14%
TOTAL                   +10  -       +0.07%

Results for commit: 02a300d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

Unit Tests Summary

       1 files       27 suites   42s ⏱️
   317 tests    317 ✔️ 0 💤 0
1 099 runs  1 099 ✔️ 0 💤 0

Results for commit 4ee5ba6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just NEWS to add here then we're good

@nikolas-burkoff
Copy link
Contributor

Actually can we remove digest from teal.data's dependencies as well?

@mhallal1
Copy link
Contributor Author

Actually can we remove digest from teal.data's dependencies as well?

It is still used in codeClass.R

@nikolas-burkoff nikolas-burkoff self-assigned this Nov 10, 2022
@mhallal1 mhallal1 merged commit 71bf77c into main Nov 11, 2022
@mhallal1 mhallal1 deleted the 751_hash_move@main branch November 11, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants