add cdisc information into JoinKeys #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: 3cbb1d7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
nikolas-burkoff
left a comment
nikolas-burkoff
left a comment
There was a problem hiding this comment.
Looking good a few comments to address then we'll take another look
R/cdisc_data.R
Outdated
| recursive = FALSE | ||
| ) | ||
|
|
||
| names(new_parents) <- unlist(lapply(data_objects, function(x) { |
Contributor
There was a problem hiding this comment.
Is there a way to create a named list without having to do it separately for new_parents and parents?
Contributor
|
JUnit report for branch |
Contributor
nikolas-burkoff
left a comment
nikolas-burkoff
left a comment
There was a problem hiding this comment.
All looks good, a few minor comments and one in teal.slice then I suggest the team run some example apps (might be worth adding ones you've been using to the PR description if you haven't already) and then this can be merged
Adds a few tests for TealData class. I didn't really see anything else to change. Should be final step for #133 --------- Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
gogonzo
reviewed
Feb 7, 2023
gogonzo
reviewed
Feb 7, 2023
gogonzo
reviewed
Feb 8, 2023
gogonzo
approved these changes
Feb 8, 2023
Contributor
gogonzo
left a comment
gogonzo
left a comment
There was a problem hiding this comment.
👍 Thanks for a huge simplification here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #120
CDISCTealDataand replaced its functionality withTealData.join_keysmentions inTealDatasetandTealDatasetConnector.cdisc_dataandteal_datato set up join_keys by callingJoinKeysfunctionalities. They check ifjoin_keysare passed otherwise they create them according to primary keys.cdisc_data_filetest-joinKeys.Rtest-TealData,test-TealDataAbstract,test-cdisc_dataandtest-teal_data.teal.slice::init_filtered_datato removeCDISCTealDataS3 method and to account forcdiscstatus in theTealDataS3 method: update init_filtered_data teal.slice#169