Skip to content

amend NEWS after 213 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chlebowa merged 2 commits into from
Dec 12, 2023
Merged

amend NEWS after 213 #216

chlebowa merged 2 commits into from
Dec 12, 2023

Conversation

@chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Dec 11, 2023

forgot to update NEWS in #214

@chlebowa chlebowa requested a review from gogonzo December 11, 2023 11:53
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                       1       1  0.00%    37
R/data_label.R                      24       5  79.17%   33-37, 72
R/datanames.R                       10       0  100.00%
R/default_cdisc_join_keys.R         11      11  0.00%    17-35
R/deprecated.R                      64      64  0.00%    16-338
R/dummy_function.R                   5       5  0.00%    16-23
R/formatters_var_labels.R           49      49  0.00%    28-151
R/join_key.R                        31       0  100.00%
R/join_keys-c.R                     26       0  100.00%
R/join_keys-extract.R              122       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               28       1  96.43%   28
R/join_keys-print.R                 46       0  100.00%
R/join_keys-utils.R                 87       2  97.70%   127, 130
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   70
R/teal_data-get_code.R              15       2  86.67%   55, 60
R/teal_data-show.R                   4       4  0.00%    13-18
R/teal_data.R                       22       9  59.09%   32, 41-47, 50
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R       87       1  98.85%   41
R/utils.R                           14       0  100.00%
R/verify.R                          42      11  73.81%   68, 98-102, 105-109
R/zzz.R                             10      10  0.00%    4-16
TOTAL                              817     176  78.46%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 61a2ceb

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

Unit Tests Summary

    1 files    15 suites   2s ⏱️
170 tests 168 ✔️ 2 💤 0 ❌
252 runs  250 ✔️ 2 💤 0 ❌

Results for commit 61a2ceb.

♻️ This comment has been updated with latest results.

@chlebowa chlebowa enabled auto-merge (squash) December 11, 2023 12:28
averissimo
averissimo approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chlebowa chlebowa merged commit 6fb2bf3 into main Dec 12, 2023
@chlebowa chlebowa deleted the NEWS@main branch December 12, 2023 16:03
@m7pr m7pr mentioned this pull request Jan 22, 2024
Merged
m7pr added a commit that referenced this pull request Jan 24, 2024
@m7pr @github-actions
@dependabot-preview @gogonzo @averissimo @chlebowa
261 multiple improvements to get_code function and it's documentati…
ca761c2 
…on (#263)

~~Close #216~~

EDIT
Close #261

---------

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: go_gonzo <dawid.kaledkowski@gmail.com>
Co-authored-by: Aleksander Chlebowski <aleksander.chlebowski@contractors.roche.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averissimo averissimo averissimo approved these changes

@gogonzo gogonzo Awaiting requested review from gogonzo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chlebowa @averissimo