Skip to content

985 parametrize name check in get_code_dependency #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m7pr merged 1 commit into from
Dec 15, 2023
Merged

985 parametrize name check in get_code_dependency #223

m7pr merged 1 commit into from
Dec 15, 2023

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Dec 15, 2023 •
edited
Loading

Alternative for #219 potentially fixes insightsengineering/teal#985 if we extend get_code_dependency usage with check_names = FALSE in teal - provided in insightsengineering/teal#1012

@m7pr m7pr added the core label Dec 15, 2023
@m7pr m7pr mentioned this pull request Dec 15, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                       1       1  0.00%    37
R/data_label.R                      24       5  79.17%   33-37, 72
R/datanames.R                       10       0  100.00%
R/default_cdisc_join_keys.R         11      11  0.00%    17-35
R/deprecated.R                      64      64  0.00%    16-338
R/dummy_function.R                   5       5  0.00%    16-23
R/formatters_var_labels.R           49      49  0.00%    28-151
R/join_key.R                        31       0  100.00%
R/join_keys-c.R                     26       0  100.00%
R/join_keys-extract.R              122       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               28       1  96.43%   28
R/join_keys-print.R                 46       0  100.00%
R/join_keys-utils.R                 87       2  97.70%   127, 130
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   70
R/teal_data-get_code.R              15       2  86.67%   55, 60
R/teal_data-show.R                   4       4  0.00%    13-18
R/teal_data.R                       22       9  59.09%   32, 41-47, 50
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R       88       1  98.86%   43
R/utils.R                           14       0  100.00%
R/verify.R                          42      11  73.81%   68, 98-102, 105-109
R/zzz.R                             10      10  0.00%    4-16
TOTAL                              818     176  78.48%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  -------
R/utils-get_code_dependency.R       +1       0  +0.01%
TOTAL                               +1       0  +0.03%

Results for commit: 76a8d6d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr mentioned this pull request Dec 15, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Unit Tests Summary

    1 files    15 suites   2s ⏱️
170 tests 168 ✔️ 2 💤 0 ❌
252 runs  250 ✔️ 2 💤 0 ❌

Results for commit 76a8d6d.

chlebowa
chlebowa approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m7pr m7pr merged commit beec3a5 into main Dec 15, 2023
@m7pr m7pr deleted the 985_fix_get_code_deps_warning@main branch December 15, 2023 14:06
m7pr added a commit to insightsengineering/teal that referenced this pull request Dec 15, 2023
@m7pr @github-actions
985 get_code_dependency check_names=FALSE (#1012)
0bc766a 
Close #985 associated with
insightsengineering/teal.data#223

---------

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chlebowa chlebowa chlebowa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

teal_data appears empty when app starts

3 participants

@m7pr @chlebowa