Skip to content

remove any.missing parameter #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
donyunardi merged 2 commits into from
Jan 3, 2024
Merged

remove any.missing parameter #243

donyunardi merged 2 commits into from
Jan 3, 2024

Conversation

@donyunardi
Copy link
Contributor

@donyunardi donyunardi commented Jan 3, 2024

Fixes #242

@donyunardi donyunardi linked an issue Jan 3, 2024 that may be closed by this pull request
Update assertion settings for col_labels #242
Closed
@donyunardi donyunardi added the core label Jan 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                       1       1  0.00%    37
R/default_cdisc_join_keys.R         11      11  0.00%    17-35
R/deprecated.R                      69      69  0.00%    16-350
R/dummy_function.R                   5       5  0.00%    16-23
R/formatters_var_labels.R           51      51  0.00%    28-154
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   33-36
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   70
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              15       1  93.33%   55
R/teal_data-show.R                   4       4  0.00%    13-18
R/teal_data.R                       22       9  59.09%   32, 41-47, 50
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      110       1  99.09%   43
R/utils.R                           14       0  100.00%
R/verify.R                          42      11  73.81%   68, 98-102, 105-109
R/zzz.R                             10      10  0.00%    4-16
TOTAL                              809     177  78.12%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/formatters_var_labels.R       +4      +4  +100.00%
TOTAL                           +4      +4  -0.39%

Results for commit: 90b7f9f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

Unit Tests Summary

  1 files   14 suites   2s ⏱️
169 tests 167 ✅ 2 💤 0 ❌
249 runs  247 ✅ 2 💤 0 ❌

Results for commit 90b7f9f.

♻️ This comment has been updated with latest results.

@chlebowa
Copy link
Contributor

chlebowa commented Jan 3, 2024

The documentation states that these functions are lifted from formatters as is. Should we modify them? Have they been changed there? This is in addition to my concerns here.

@chlebowa
Copy link
Contributor

chlebowa commented Jan 3, 2024

Following the logic outlined in the documentation, value should allow NAs.

chlebowa
chlebowa approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@donyunardi donyunardi enabled auto-merge (squash) January 3, 2024 21:49
@donyunardi donyunardi merged commit 129e0df into main Jan 3, 2024
@donyunardi donyunardi deleted the 242-update-assertion-settings-for-col_labels branch January 3, 2024 21:52
@donyunardi donyunardi mentioned this pull request Jan 3, 2024
Merged
donyunardi added a commit to insightsengineering/teal.transform that referenced this pull request Jan 3, 2024
@donyunardi
Fixed failed integration test (#170)
11ce5cd 
Fixes #169

* related with insightsengineering/teal.data/pull/243
* update unit test to use latest syntax for `join_keys` statement
* update DESC file on teal.data version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chlebowa chlebowa chlebowa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update assertion settings for col_labels

3 participants

@donyunardi @chlebowa