249 remove check for datanames parameter being a subset of datanames(teal_data) in get_code(teal_data)

[m7pr]

Close #249

This PR removed a check in get_code(teal_data) that was veryfing if datanames parameter is a subset of datanames(teal_data). Since datanames() is now optional, we do not need to have this check, and we can allow to specify code extraction for any object inside the code.

• removed datanames() <- calls from tests of get_code()
• removed datanames() <- calls from examples of get_code()

[github-actions]

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------
R/cdisc_data.R                       1       1  0.00%    35
R/default_cdisc_join_keys.R         11      11  0.00%    17-35
R/deprecated.R                      57      57  0.00%    17-341
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           36      11  69.44%   59, 68-79
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   33-36
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   70
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    13-18
R/teal_data.R                       22       9  59.09%   28, 37-43, 46
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      110       0  100.00%
R/verify.R                          42      11  73.81%   63, 93-97, 100-104
R/zzz.R                             10      10  0.00%    4-16
TOTAL                              764     120  84.29%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  -------
R/teal_data-get_code.R              -1      -1  +6.67%
R/utils-get_code_dependency.R        0      -1  +0.91%
TOTAL                               -1      -2  +0.24%

Results for commit: 060248c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   14 suites   2s ⏱️
175 tests 173 ✅ 2 💤 0 ❌
242 runs  240 ✅ 2 💤 0 ❌

Results for commit 060248c.

♻️ This comment has been updated with latest results.

[chlebowa]

Now that datanames is optional, I think the vignette should briefly mention what it is used for.

[m7pr]

Now that datanames is optional, I think the vignette should briefly mention what it is used for.

Sure, we can create a new issue for that

[chlebowa]

Now that datanames is optional, I think the vignette should briefly mention what it is used for.

Sure, we can create a new issue for that

Please open one and assign me to it.

[chlebowa]

👍

[m7pr]

Created an issue here #251