Append testthat prefix for join_keys tests

[m7pr]

🥇

[github-actions]

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------
R/cdisc_data.R                       1       1  0.00%    38
R/default_cdisc_join_keys.R         11      11  0.00%    16-34
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           36      11  69.44%   60, 69-80
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   69
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       22       9  59.09%   31, 40-46, 49
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      128       0  100.00%
R/verify.R                          42      11  73.81%   63, 93-97, 100-104
R/zzz.R                             10      10  0.00%    4-16
TOTAL                              782     120  84.65%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a77391f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   14 suites   1s ⏱️
176 tests 174 ✅ 2 💤 0 ❌
244 runs  242 ✅ 2 💤 0 ❌

Results for commit a77391f.

[averissimo]

Added a few that were missing.

Seems good!

Q: Can you point me to documentation or issue where this convention of prefixing test´that:: is defined?

[chlebowa]

🥇

[chlebowa]

Q: Can you point me to documentation or issue where this convention of prefixing test´that:: is defined?

I don't believe there is one but the conventions is: in tests, prefix everything not native to the package tested. This goes even for shiny in Depends: shiny packages such as teal,

[averissimo]

The insightsengineering packages are the first place I see this being applied for {testthat} expectations, test_that() and other {testthat} functions, hence the question.

My question was solely about {testthat} :-) shiny & others make obvious sense.

[chlebowa]

Like many NEST conventions, I wasn't here when they were adopted, so I merely pass them on 🙂

[averissimo]

@pawelru care to give some context? 😁

[pawelru]

hmmm can't recall tbh
either way it's ok - the most important thing is to stay consistent within a package