Skip to content

Conversation

@chlebowa
Copy link
Contributor

Closes #251

@chlebowa chlebowa added the core label Jan 24, 2024
@chlebowa chlebowa requested a review from a team January 24, 2024 14:13
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------
R/cdisc_data.R                       1       1  0.00%    38
R/default_cdisc_join_keys.R         11      11  0.00%    16-34
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           36      11  69.44%   60, 69-80
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   69
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       22       9  59.09%   35, 44-50, 53
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      166       1  99.40%   258
R/verify.R                          42      11  73.81%   63, 93-97, 100-104
R/zzz.R                             10      10  0.00%    4-16
TOTAL                              820     121  85.24%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: dc51bbe

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Unit Tests Summary

  1 files   14 suites   1s ⏱️
175 tests 173 ✅ 2 💤 0 ❌
243 runs  241 ✅ 2 💤 0 ❌

Results for commit dc51bbe.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this Jan 24, 2024
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, those 2 vignettes cover a lot of basic and advanced usage. They are both complement each other in a way where each focus on specific details, but they both created a whole full picture of teal_data object and it's typical ways of using it. Great job explaining that. If only all the software in the world had such thoroughly written documentation

@averissimo averissimo self-assigned this Jan 24, 2024
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wunderbar 💪

Co-authored-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Signed-off-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

1 minor comment that shouldn't block the merge.

ps. just like @m7pr said, it would be nice if all documentation was this good

@chlebowa chlebowa merged commit 37e7ff4 into main Jan 24, 2024
@chlebowa chlebowa deleted the 251_update_vignettes@main branch January 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update vignettes

6 participants