Adds test for gtsummary module#975
Merged
m7pr merged 18 commits intotm_gtsummaryfrom Feb 5, 2026
Merged
Conversation
This was referenced Feb 3, 2026
Merged
Contributor
Author
|
Test coverage is currently |
m7pr
reviewed
Feb 4, 2026
m7pr
reviewed
Feb 4, 2026
m7pr
reviewed
Feb 4, 2026
m7pr
reviewed
Feb 4, 2026
m7pr
reviewed
Feb 4, 2026
Contributor
|
@llrs-roche for the decorators tests we could use this snippet #973 (comment) |
…eneral into tests
llrs-roche
added a commit
that referenced
this pull request
Feb 5, 2026
# Pull Request check_decorators didn't raise the error that the decorators provided included something for an object that shouldn't be decorated! Before: ```r check_decorators(list(plot = teal::teal_transform_module()), "plot") ## TRUE check_decorators(list(plot = teal::teal_transform_module()), "table") ## TRUE ``` After: ```r check_decorators(list(plot = teal::teal_transform_module()), "plot") ## TRUE check_decorators(list(plot = teal::teal_transform_module()), "table") ## [1] "The `decorators` must be a named list from these names: table." ``` I haven't added tests as the functions are not exported but was found while working on #975 Once accepted a PR on teal.modules.clinical should be opened with the same changes --------- Signed-off-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com> Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
m7pr
approved these changes
Feb 5, 2026
Contributor
m7pr
left a comment
m7pr
left a comment
There was a problem hiding this comment.
@llrs-roche if you can resolve that, then I think we can merge
Signed-off-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Adds tests for #973
TODO:
On a different PR: