Conversation
Contributor
|
✅ All contributors have signed the CLA |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Code Coverage SummaryDiff against mainResults for commit: a92ca0e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 25 suites 7s ⏱️ Results for commit a92ca0e. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit ebdbd7a ♻️ This comment has been updated with latest results. |
m7pr
reviewed
Jan 19, 2026
m7pr
reviewed
Jan 19, 2026
m7pr
approved these changes
Jan 19, 2026
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com> Signed-off-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
averissimo
approved these changes
Feb 12, 2026
Contributor
averissimo
left a comment
There was a problem hiding this comment.
Minor comments, please address them and you're ok to merge
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Oriol Senan <35930244+osenan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Adding missing unit test listed in here #288
The added test do not fail for me. However, one tests of the package fail locally.
To review, expect the CI to no have any failures with tests.
Individual test can be checked with
devtools::load_all()andtestthat::test_file