Skip to content

Fix failing linters#290

Merged
osenan merged 5 commits into
mainfrom
fix_lintr@main
Feb 17, 2026
Merged

Fix failing linters#290
osenan merged 5 commits into
mainfrom
fix_lintr@main

Conversation

@osenan
Copy link
Copy Markdown
Contributor

@osenan osenan commented Feb 13, 2026

There were two lintr errors from previous PR that were not fixed. This PR keeps the linter clean to have passing CI. To review it, check that all CI is passed.

@osenan osenan added the core label Feb 13, 2026
@osenan osenan changed the title chore: fix lintr Fix failing linters Feb 13, 2026
@osenan osenan requested a review from a team February 13, 2026 11:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2026

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------------
R/call_utils.R                      163     125  23.31%   19-28, 65, 67, 69, 102-345, 405
R/check_selector.R                   33       0  100.00%
R/choices_labeled.R                 157      27  82.80%   67, 73, 78, 85, 101, 218-222, 226-231, 354-355, 357, 363, 390-397
R/choices_selected.R                 81       3  96.30%   212, 218, 274
R/column_functions.R                  4       1  75.00%   19
R/data_extract_datanames.R           30       0  100.00%
R/data_extract_filter_module.R      105      47  55.24%   95-108, 110-111, 113-130, 146-165
R/data_extract_module.R             305      67  78.03%   139, 144, 161, 164-169, 171, 190-193, 223-269, 507, 512, 688, 699-700, 778-783
R/data_extract_read_module.R        137       7  94.89%   34, 39-41, 43, 138, 155
R/data_extract_select_module.R       32      18  43.75%   29-46
R/data_extract_single_module.R       60       2  96.67%   30, 43
R/data_extract_spec.R                32       0  100.00%
R/delayed_choices.R                  34       6  82.35%   86, 95-99
R/filter_spec.R                     186       1  99.46%   279
R/format_data_extract.R              16       1  93.75%   48
R/get_dplyr_call.R                  297       0  100.00%
R/get_merge_call.R                  276      29  89.49%   31-37, 48, 214-223, 387, 402-414
R/input_checks.R                     11       2  81.82%   15-16
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  137       6  95.62%   122, 254-258
R/merge_expression_module.R          60      11  81.67%   160-165, 183, 359-364
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       4  75.00%   76-79
R/resolve.R                         115      45  60.87%   46, 180-286
R/select_spec.R                      64       8  87.50%   98, 178-185
R/utils.R                            37      24  35.14%   31-44, 172-185
R/zzz.R                               3       3  0.00%    2-4
TOTAL                              2416     437  81.91%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  -------
R/column_functions.R       +1       0  +8.33%
R/get_merge_call.R         -2       0  -0.08%
TOTAL                      -1       0  -0.01%

Results for commit: c5cc007

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2026

Unit Tests Summary

  1 files   25 suites   6s ⏱️
201 tests 201 ✅ 0 💤 0 ❌
710 runs  710 ✅ 0 💤 0 ❌

Results for commit c5cc007.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what are the lintr issues identified on column_functions.R but I think we could make it more readable and at the same time pass the lintr

Comment thread R/column_functions.R Outdated
@llrs-roche llrs-roche self-assigned this Feb 13, 2026
Co-authored-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com>
Signed-off-by: Oriol Senan  <35930244+osenan@users.noreply.github.com>
@osenan
Copy link
Copy Markdown
Contributor Author

osenan commented Feb 13, 2026

The issues were the line length. I tried to break the line and then the sytler bot was changing the line. Then the linter was failing again. That is why I decided to apply a small refactor.
But you solution was much better!!

@osenan osenan requested a review from llrs-roche February 17, 2026 14:10
@osenan osenan enabled auto-merge (squash) February 17, 2026 14:15
Copy link
Copy Markdown
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osenan osenan merged commit f094a32 into main Feb 17, 2026
26 checks passed
@osenan osenan deleted the fix_lintr@main branch February 17, 2026 14:22
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants