Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Feb 21, 2025

Part of https://github.com/insightsengineering/coredev-tasks/issues/609

From now on, we will provide development dependencies in

Remotes: repo/project@branch

format, so it's explicitly visible in the DESCRIPTION file and can be handled by pak::install, renv::install and remotes::install.

With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.

@m7pr m7pr added the core label Feb 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ----------
R/assert_data.R           63       0  100.00%
R/covariance_plot.R       52       5  90.38%   41, 84-87
R/fit_mmrm.R              44       0  100.00%
R/formula.R               45       0  100.00%
R/g_mmrm.R               314       7  97.77%   66-71, 306
R/labels.R                23       0  100.00%
R/lsmeans.R              205       0  100.00%
R/subgroups.R            265       0  100.00%
R/tabulate_mmrm.R         83       0  100.00%
R/utils.R                  4       0  100.00%
TOTAL                   1098      12  98.91%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: b56e0bd

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Unit Tests Summary

  1 files   11 suites   14s ⏱️
110 tests  81 ✅ 29 💤 0 ❌
219 runs  178 ✅ 41 💤 0 ❌

Results for commit b56e0bd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
subgroups 💚 $4.94$ $-1.54$ $-2$ $+4$ $0$ $0$

Results for commit a1dfdb9

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Feb 21, 2025

I have read the CLA Document and I hereby sign the CLA

@m7pr
Copy link
Contributor Author

m7pr commented Feb 21, 2025

recheck

@m7pr m7pr enabled auto-merge (squash) February 21, 2025 10:19
Copy link

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three packages were published on CRAN so no Remotes is needed. Nice!

@m7pr m7pr merged commit 8041fd0 into main Feb 21, 2025
27 checks passed
@m7pr m7pr deleted the remove_lookups branch February 21, 2025 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@llrs-roche llrs-roche self-assigned this Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants