Skip to content

1418 [Bug]: g_lineplot doesn't work with a format as a function #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Melkiades merged 6 commits into from
May 20, 2025
Merged

1418 [Bug]: g_lineplot doesn't work with a format as a function #1421

Melkiades merged 6 commits into from
May 20, 2025

Conversation

@yurovska
Copy link
Contributor

@yurovska yurovska commented May 17, 2025 •
edited
Loading

Fixes #1418

@yurovska yurovska marked this pull request as ready for review May 17, 2025 11:04
@yurovska
Copy link
Contributor Author

yurovska commented May 17, 2025

@Melkiades I've also fixed table_format and table_labels args, which were completely ignored in the g_lineplot.

Ready for review.

Melkiades
Melkiades reviewed May 19, 2025
View reviewed changes
Melkiades
Melkiades reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good!! Can I ask you to add into the function reference about the possible function input? Thanks! :)

@yurovska
Copy link
Contributor Author

yurovska commented May 19, 2025

It looks very good!! Can I ask you to add into the function reference about the possible function input? Thanks! :)

Thanks for your comment. Documentation has been slightly updated.

Melkiades
Melkiades approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good to go. Thanks for the terrific job :)

@yurovska
Copy link
Contributor Author

yurovska commented May 20, 2025

Looks great! Good to go. Thanks for the terrific job :)

@Melkiades Thanks for the review. I do not have permission to merge, so please do so.

@Melkiades Melkiades merged commit b897ee3 into insightsengineering:main May 20, 2025
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
@yurovska yurovska deleted the 1418-g_lineplot-fix branch May 20, 2025 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Melkiades Melkiades Melkiades approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: g_lineplot doesn't work with a format as a function

2 participants

@yurovska @Melkiades