-
-
Notifications
You must be signed in to change notification settings - Fork 28
1445: Add cmh_sato method to estimate_proportion_diff()
#1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
1445: Add cmh_sato method to estimate_proportion_diff()
#1449
Conversation
|
I have read the CLA Document and I hereby sign the CLA |
…st, update snapshots accordingly
Melkiades
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question. Otherwise looks very good!! Thanks. I will run revdeps too ;)
|
Thanks @Melkiades , I see some unrelated check failures, cannot do much about those |
Melkiades
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!! Thanks @danielinteractive! Issues stem from recent merging of round_type from J&J. Merge of rtables'PRs should fix these. Maybe we can merge this anyway ^^
|
upstream pr has been merged and I've confirmed that the vignettes build for me locally with the latest formatters and rtables (which is what was failing in the GH action). Assumedly this is a cache issue and will clear once it gets the right versions of things. I'll leave the rest to you @Melkiades |
|
Thanks @gmbecker ! I just retriggered checks, they failed again but I guess the new version of |
|
hi Daniel, can you add the following lines to the DESCRIPTION this will help to get the right versions |
|
also need to bump the minimal version for formatters and rtables in the description |
closes #1445