Skip to content

Conversation

@danielinteractive
Copy link
Collaborator

closes #1445

@danielinteractive
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question. Otherwise looks very good!! Thanks. I will run revdeps too ;)

@danielinteractive
Copy link
Collaborator Author

Thanks @Melkiades , I see some unrelated check failures, cannot do much about those

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!! Thanks @danielinteractive! Issues stem from recent merging of round_type from J&J. Merge of rtables'PRs should fix these. Maybe we can merge this anyway ^^

@gmbecker
Copy link
Collaborator

gmbecker commented Dec 8, 2025

upstream pr has been merged and I've confirmed that the vignettes build for me locally with the latest formatters and rtables (which is what was failing in the GH action). Assumedly this is a cache issue and will clear once it gets the right versions of things. I'll leave the rest to you @Melkiades

@danielinteractive
Copy link
Collaborator Author

Thanks @gmbecker ! I just retriggered checks, they failed again but I guess the new version of rtables has not arrived here for some reason?

@shajoezhu
Copy link
Contributor

hi Daniel, can you add the following lines to the DESCRIPTION

Remotes:
    insightsengineering/formatters@main,
    insightsengineering/rtables@main

this will help to get the right versions

@shajoezhu
Copy link
Contributor

also need to bump the minimal version for formatters and rtables in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: prop_diff enhancement proposal

4 participants