Update roxygen2 to 8.0.0 and add @exportS3Method tags#1477
Merged
Conversation
Replace @nord with @exportS3Method for S3 methods in decorate_grob.R and utils_grid.R to comply with roxygen2 8.0.0 requirements. Also store border, padding, and margins on the gTree object in decorate_grob() so validDetails.decoratedGrob() can access them.
Contributor
Code Coverage SummaryDiff against mainResults for commit: d2d2491 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 85 suites 1m 43s ⏱️ Results for commit d2d2491. ♻️ This comment has been updated with latest results. |
llrs-roche
approved these changes
May 19, 2026
llrs-roche
left a comment
There was a problem hiding this comment.
Nice update, I see lots of links updated and methods properly used.
Now that the methods are used I think it exposes some grid checks that require some extra 3 parameters on grid::gTree(), well done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RoxygenNotein DESCRIPTION from 7.3.3 to 8.0.0.@noRdwith@exportS3Methodfor 8 S3 methods indecorate_grob.Randutils_grid.Rthatroxygen28.0.0 requires to be explicitly tagged.border,padding, andmarginson thegTreeobject indecorate_grob()sovalidDetails.decoratedGrob()can access them (was causing assertion failures).roxygen28.0.0.Affected S3 methods
decorate_grob.RvalidDetails.decoratedGrobdecorate_grob.RwidthDetails.decoratedGrobdecorate_grob.RheightDetails.decoratedGrobdecorate_grob.RvalidDetails.dynamicSplitTextdecorate_grob.RheightDetails.dynamicSplitTextdecorate_grob.RwidthDetails.dynamicSplitTextdecorate_grob.RdrawDetails.dynamicSplitTextutils_grid.Rprint.ternGrob