Skip to content

Fixes #141 - Add AWS ElastiCache cluster resources#201

Merged
skpaterson merged 33 commits intomasterfrom
aws_elasticache_cluster
Apr 27, 2020
Merged

Fixes #141 - Add AWS ElastiCache cluster resources#201
skpaterson merged 33 commits intomasterfrom
aws_elasticache_cluster

Conversation

@omerdemirok
Copy link
Copy Markdown

@omerdemirok omerdemirok commented Apr 24, 2020 •
edited
Loading

Signed-off-by: Omer Demirok odemirok@chef.io

Description

Add new resources

  • aws_elasticache_cluster
  • aws_elasticache_cluster_node
  • aws_elasticache_clusters

Issues Resolved

Feature Request: #141

Check List

Please fill box or appropriate ([x]) or mark N/A.

Omer Demirok added 21 commits April 22, 2020 16:17
Add Elasticache Cluster Node resource
fff1693 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add Elasticache Cluster resource
1d3b826 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Fix a typo
cb5e2dd 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add Elasticache Clusters - plural - resource
57cf6c2 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add aws-sdk-elasticache
ad1be42 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add node_ids method
1e40400 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add aws-elasticache-sdk
ccf316c 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add status and port methods
6ff6aae 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Refactor class and file names
d1c88ed 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Replace depricated switch
3fc2acb 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add tests for elasti cache resources
2099505 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add docs for ElastiCache resources
af837d1 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add comment for cluster tags
83e16c4 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Refactor error message
06bc1ac 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Shorten table headers
c2a6bcc 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add contion to prevent nil class method access
5b92eb4 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Add contion to prevent nil class method access
65e623b 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Refactor tests
8e898e6 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Refactor conditions.
3ecacbb 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Fix some typos
ade9366 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Fix some typos
e587958 
Signed-off-by: Omer Demirok <odemirok@chef.io>
@omerdemirok omerdemirok requested a review from a team as a code owner April 24, 2020 13:05
@omerdemirok omerdemirok self-assigned this Apr 24, 2020
rmoles
rmoles reviewed Apr 24, 2020
View reviewed changes
Comment thread libraries/aws_elasti_cache_cluster.rb Outdated
rmoles
rmoles reviewed Apr 24, 2020
View reviewed changes
Comment thread libraries/aws_elasti_cache_cluster_node.rb Outdated
Omer Demirok added 2 commits April 24, 2020 15:28
Refactor resource not found condition
09b7aab 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Fix a lint issue
4f07937 
Signed-off-by: Omer Demirok <odemirok@chef.io>
skpaterson
skpaterson suggested changes Apr 24, 2020
View reviewed changes
Copy link
Copy Markdown

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @omer-chefio! Have a few small suggestions.

Comment thread docs/resources/aws_elasti_cache_cluster.md Outdated
Comment thread libraries/aws_elasti_cache_cluster.rb Outdated
Comment thread test/unit/resources/aws_elasti_cache_cluster_node_test.rb Outdated
rmoles
rmoles reviewed Apr 24, 2020
View reviewed changes
Comment thread libraries/aws_elasti_cache_cluster_node.rb Outdated
Uncomment unit tests
d5ac9bc 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Omer Demirok added 9 commits April 24, 2020 16:33
Remove redundant check on api responce
8988392 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Remove redundant check on API response
65c7d79 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Rename elasti_cache to elasticache
c43dcbc 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Refactor condition
5a0a768 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Update docs with new resource name
169b47e 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Check for nil class method access
98feb3f 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Create stub cluster for node testing
150a76d 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Update "ports" method of cluster resource
e4d4f94 
Signed-off-by: Omer Demirok <odemirok@chef.io>
Fix a rubocop offense
57dd0d3 
Signed-off-by: Omer Demirok <odemirok@chef.io>
rmoles
rmoles reviewed Apr 27, 2020
View reviewed changes
Comment thread libraries/aws_elasticache_cluster.rb
@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Apr 27, 2020
@skpaterson skpaterson merged commit 0cdc93d into master Apr 27, 2020
@skpaterson skpaterson deleted the aws_elasticache_cluster branch April 27, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rmoles rmoles rmoles left review comments

@skpaterson skpaterson skpaterson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@omerdemirok omerdemirok

Labels

Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omerdemirok @rmoles @skpaterson