Conversation
…ory does not have .git directory (#6626) * Functional Test to verify git fetcher able to work in a directory where git is not initialized or does not contain the .git directory Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io> * Fix: If git branch, tag or reference information is not given it should clone the repo and checkout the default HEAD Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io> * Remove the logic to find default branch in case of branch, tag or ref is not provided as it's not required logically as we will be cloning the and checkout the default HEAD Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com> * This is a temporary change to make verify test working on this PR. Revert once the work is done for the git fetcher fix Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com> * Unit Test: Fix unit test Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com> * Verifies the git url before creating cache_key, if given relative path does not exist make sure it deletes the cache directory created to copy the cloned repo. It raises error if any git command fails Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com> * Reverted verify git repo url call from cache_key as cache_key and shifted that to resolve_ref which is already raising the error in case of git ls remote command fails Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com> * Unit test to cover the changes done for resolve_ref when branch, tag or ref is not given and unit test for invalid git repo Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com> --------- Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io> Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Vasu1105
requested review from
ahasunos and
clintoncwolfe
and removed request for
a team
Contributor
Author
|
Merging this as this is backport of #6626 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #6626 to InSpec 5
Related Issue
Types of changes
Checklist: