Skip to content

CHEF-8990 Remove dependency on active-support function blank?#6914

Merged
clintoncwolfe merged 2 commits intomainfrom
nm/active-support-blank-usage-remove
Jan 4, 2024
Merged

CHEF-8990 Remove dependency on active-support function blank?#6914
clintoncwolfe merged 2 commits intomainfrom
nm/active-support-blank-usage-remove

Conversation

@Nik08
Copy link
Copy Markdown
Contributor

@Nik08 Nik08 commented Dec 18, 2023

Description

Remove dependency on active-support function blank?
Since active-support is not declared as a dependency for inspec-core it breaks the usage of inspec.

Fixes #6527

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@Nik08 Nik08 requested a review from a team as a code owner December 18, 2023 13:03
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 18, 2023

Deploy Preview for chef-inspec canceled.

Name Link
🔨 Latest commit 5adcdcb
🔍 Latest deploy log https://app.netlify.com/sites/chef-inspec/deploys/65817b7dc83d490008533b93

@Nik08 Nik08 changed the title [W.I.P] Remove dependency on active-support function blank? [W.I.P] CHEF-8990 Remove dependency on active-support function blank? Dec 18, 2023
…nspec-core)

Signed-off-by: Nik08 <nikita.mathur@progress.com>
Signed-off-by: Nik08 <nikita.mathur@progress.com>
@Nik08 Nik08 force-pushed the nm/active-support-blank-usage-remove branch from dbbb9fc to 5adcdcb Compare December 19, 2023 11:16
@Nik08 Nik08 changed the title [W.I.P] CHEF-8990 Remove dependency on active-support function blank? CHEF-8990 Remove dependency on active-support function blank? Dec 19, 2023
@Nik08 Nik08 added the inspec-6 label Dec 19, 2023
@tpowell-progress
Copy link
Copy Markdown

@Nik08 is there a inspec-5 backport on the radar? Chef 17 and 18 are breaking in certain environments due to this

@tpowell-progress
Copy link
Copy Markdown

@Nik08 is there a inspec-5 backport on the radar? Chef 17 and 18 are breaking in certain environments due to this

Nevermind I just found #6916

@clintoncwolfe clintoncwolfe merged commit 565df50 into main Jan 4, 2024
@clintoncwolfe clintoncwolfe deleted the nm/active-support-blank-usage-remove branch January 4, 2024 17:25
Nik08 added a commit that referenced this pull request Sep 13, 2024
* Removed usage of blank? to solve active-support gem issue (Issue in inspec-core)

Signed-off-by: Nik08 <nikita.mathur@progress.com>

* Linting fix

Signed-off-by: Nik08 <nikita.mathur@progress.com>

---------

Signed-off-by: Nik08 <nikita.mathur@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undocumented Dependency on ActiveSupport

5 participants